fix: internally wrap store subscribe in untrack (#13858)

* fix: internally wrap store subscribe in untrack

* lint

* Update packages/svelte/src/store/utils.js

Co-authored-by: Simon H <[email protected]>

---------

Co-authored-by: Simon H <[email protected]>

Author: trueadm

.changeset/little-hotels-poke.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: internally wrap store subscribe in untrack

packages/svelte/src/store/utils.js

@@ -1,4 +1,5 @@
 /** @import { Readable } from './public' */
+import { untrack } from '../index-client.js';
 import { noop } from '../internal/shared/utils.js';
 
 /**
@@ -20,10 +21,13 @@ export function subscribe_to_store(store, run, invalidate) {
 	}
 
 	// Svelte store takes a private second argument
-	const unsub = store.subscribe(
-		run,
-		// @ts-expect-error
-		invalidate
+	// StartStopNotifier could mutate state, and we want to silence the corresponding validation error
+	const unsub = untrack(() =>
+		store.subscribe(
+			run,
+			// @ts-expect-error
+			invalidate
+		)
 	);
 
 	// Also support RxJS

packages/svelte/tests/runtime-runes/samples/store-unsubscribe-not-referenced-after/main.svelte

@@ -1,5 +1,4 @@
 <script>
-	import { untrack } from "svelte";
 	import { writable, derived } from "svelte/store";
 
 	const obj = writable({ a: 1 });
@@ -8,9 +7,7 @@
 
 	function watch (prop) {
 		return derived(obj, (o) => {
-			untrack(() => {
-				count++;
-			});
+			count++;
 			return o[prop];
 		});
 	}