Skip to content

Commit 63b5ebf

Browse files
fix: silence a11y warning for inert elements (#16339)
* fix: silence a11y warning for inert elements * changeset * handle `inert=""` * oops --------- Co-authored-by: Rich Harris <[email protected]>
1 parent 0672e48 commit 63b5ebf

File tree

3 files changed

+10
-1
lines changed

3 files changed

+10
-1
lines changed

.changeset/tall-avocados-repair.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'svelte': patch
3+
---
4+
5+
fix: silence a11y warning for inert elements

packages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y/index.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -387,7 +387,10 @@ export function check_element(node, context) {
387387
switch (node.name) {
388388
case 'a':
389389
case 'button': {
390-
const is_hidden = get_static_value(attribute_map.get('aria-hidden')) === 'true';
390+
const is_hidden =
391+
get_static_value(attribute_map.get('aria-hidden')) === 'true' ||
392+
get_static_value(attribute_map.get('inert')) !== null;
393+
391394
if (!has_spread && !is_hidden && !is_labelled && !has_content(node)) {
392395
w.a11y_consider_explicit_label(node);
393396
}

packages/svelte/tests/validator/samples/a11y-consider-explicit-label/input.svelte

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
<a href="/#" aria-label="Valid empty link"></a>
66

77
<button aria-hidden='true'></button>
8+
<button inert></button>
89
<a href="/#" aria-hidden='true'><b></b></a>
910

1011
<button>Click me</button>

0 commit comments

Comments
 (0)