fix: allow boolean contenteditable attribute (#10590)

fixes #10559

Author: dummdidumm

.changeset/spotty-turkeys-sparkle.md

@@ -0,0 +1,5 @@
+---
+"svelte": patch
+---
+
+fix: allow boolean `contenteditable` attribute

packages/svelte/src/compiler/errors.js

@@ -371,10 +371,6 @@ const errors = {
 	// 	message:
 	// 		"'contenteditable' attribute is required for textContent, innerHTML and innerText two-way bindings"
 	// },
-	// dynamic_contenteditable_attribute: {
-	// 	code: 'dynamic-contenteditable-attribute',
-	// 	message: "'contenteditable' attribute cannot be dynamic if element uses two-way binding"
-	// },
 	// textarea_duplicate_value: {
 	// 	code: 'textarea-duplicate-value',
 	// 	message:

packages/svelte/src/compiler/phases/2-analyze/validation.js

@@ -475,7 +475,7 @@ const validation = {
 					);
 					if (!contenteditable) {
 						error(node, 'missing-contenteditable-attribute');
-					} else if (!is_text_attribute(contenteditable)) {
+					} else if (!is_text_attribute(contenteditable) && contenteditable.value !== true) {
 						error(contenteditable, 'dynamic-contenteditable-attribute');
 					}
 				}

packages/svelte/tests/validator/samples/contenteditable-dynamic/errors.json

@@ -3,11 +3,11 @@
 		"code": "dynamic-contenteditable-attribute",
 		"message": "'contenteditable' attribute cannot be dynamic if element uses two-way binding",
 		"start": {
-			"line": 6,
+			"line": 11,
 			"column": 8
 		},
 		"end": {
-			"line": 6,
+			"line": 11,
 			"column": 32
 		}
 	}

packages/svelte/tests/validator/samples/contenteditable-dynamic/input.svelte

@@ -3,4 +3,9 @@
 
     let toggle = false;
 </script>
+<!-- ok -->
+<editor contenteditable="true" bind:innerHTML={name}></editor>
+<editor contenteditable="" bind:innerHTML={name}></editor>
+<editor contenteditable bind:innerHTML={name}></editor>
+<!-- error -->
 <editor contenteditable={toggle} bind:innerHTML={name}></editor>