fix: improve unowned derived performance

trueadm · trueadm · commit 6c6647f9bc18 · 2024-12-16T17:50:30.000Z
diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js
@@ -231,8 +231,8 @@ export function check_dirtiness(reaction) {
 		}
 
 		// Unowned signals should never be marked as clean unless they
-		// are used within an active_effect
-		if (!is_unowned || active_effect !== null) {
+		// are used within an active_effect without skip_reaction
+		if (!is_unowned || (active_effect !== null && !skip_reaction)) {
 			set_signal_status(reaction, CLEAN);
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -231,8 +231,8 @@ export function check_dirtiness(reaction) {`
`231`	`231`	`}`
`232`	`232`
`233`	`233`	`// Unowned signals should never be marked as clean unless they`
`234`		`- // are used within an active_effect`
`235`		`- if (!is_unowned \|\| active_effect !== null) {`
	`234`	`+ // are used within an active_effect without skip_reaction`
	`235`	`+ if (!is_unowned \|\| (active_effect !== null && !skip_reaction)) {`
`236`	`236`	`set_signal_status(reaction, CLEAN);`
`237`	`237`	`}`
`238`	`238`	`}`