use attribute metadata

Author: Rich-Harris

packages/svelte/src/compiler/phases/2-analyze/visitors/Attribute.js

@@ -1,7 +1,7 @@
 /** @import { ArrowFunctionExpression, Expression, FunctionDeclaration, FunctionExpression } from 'estree' */
 /** @import { AST, DelegatedEvent, SvelteNode } from '#compiler' */
 /** @import { Context } from '../types' */
-import { is_capture_event, is_delegated } from '../../../../utils.js';
+import { is_boolean_attribute, is_capture_event, is_delegated } from '../../../../utils.js';
 import {
 	get_attribute_chunks,
 	get_attribute_expression,
@@ -16,9 +16,10 @@ import { mark_subtree_dynamic } from './shared/fragment.js';
 export function Attribute(node, context) {
 	context.next();
 
+	const parent = /** @type {SvelteNode} */ (context.path.at(-1));
+
 	// special case
 	if (node.name === 'value') {
-		const parent = /** @type {SvelteNode} */ (context.path.at(-1));
 		if (parent.type === 'RegularElement' && parent.name === 'option') {
 			mark_subtree_dynamic(context.path);
 		}
@@ -28,6 +29,10 @@ export function Attribute(node, context) {
 		mark_subtree_dynamic(context.path);
 	}
 
+	if (parent.type === 'RegularElement' && is_boolean_attribute(node.name.toLowerCase())) {
+		node.metadata.expression.can_inline = false;
+	}
+
 	if (node.value !== true) {
 		for (const chunk of get_attribute_chunks(node.value)) {
 			if (chunk.type !== 'ExpressionTag') continue;
@@ -41,6 +46,7 @@ export function Attribute(node, context) {
 
 			node.metadata.expression.has_state ||= chunk.metadata.expression.has_state;
 			node.metadata.expression.has_call ||= chunk.metadata.expression.has_call;
+			node.metadata.expression.can_inline &&= chunk.metadata.expression.can_inline;
 		}
 
 		if (is_event_attribute(node)) {

packages/svelte/src/compiler/phases/3-transform/client/visitors/RegularElement.js

@@ -14,7 +14,6 @@ import { dev, is_ignored, locator } from '../../../../state.js';
 import { is_event_attribute, is_text_attribute } from '../../../../utils/ast.js';
 import * as b from '../../../../utils/builders.js';
 import { is_custom_element_node } from '../../../nodes.js';
-import { is_inlinable_attribute } from '../../../utils.js';
 import { clean_nodes, determine_namespace_for_children } from '../../utils.js';
 import { build_getter, create_derived } from '../utils.js';
 import {
@@ -593,7 +592,7 @@ function build_element_attribute_update_assignment(element, node_id, attribute,
 	// we need to special case textarea value because it's not an actual attribute
 	const can_inline =
 		(attribute.name !== 'value' || element.name !== 'textarea') &&
-		is_inlinable_attribute(attribute);
+		attribute.metadata.expression.can_inline;
 
 	if (can_inline) {
 		/** @type {Literal | undefined} */

packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/fragment.js

@@ -5,7 +5,6 @@
 import { escape_html } from '../../../../../../escaping.js';
 import { is_event_attribute } from '../../../../../utils/ast.js';
 import * as b from '../../../../../utils/builders.js';
-import { is_inlinable_attribute } from '../../../../utils.js';
 import { build_template_chunk, build_update } from './utils.js';
 
 /**
@@ -156,7 +155,7 @@ function is_static_element(node) {
 			return false;
 		}
 
-		if (!is_inlinable_attribute(attribute)) {
+		if (!attribute.metadata.expression.can_inline) {
 			return false;
 		}
 	}