chore: remove managed_effect (#10926)

* chore: remove managed_effect

* remove managed_pre_effect

Author: Rich-Harris

packages/svelte/src/internal/client/dom/elements/bindings/media.js

@@ -1,5 +1,5 @@
 import { hydrating } from '../../hydration.js';
-import { destroy_effect, managed_effect, render_effect } from '../../../reactivity/effects.js';
+import { render_effect, user_effect } from '../../../reactivity/effects.js';
 import { listen } from './shared.js';
 
 /** @param {TimeRanges} ranges */
@@ -115,48 +115,22 @@ export function bind_ready_state(media, update) {
 export function bind_playback_rate(media, get_value, update) {
 	var updating = false;
 
-	var callback = () => {
-		if (!updating) {
-			update(media.playbackRate);
-		}
-		updating = false;
-	};
-
 	// Needs to happen after the element is inserted into the dom, else playback will be set back to 1 by the browser.
 	// For hydration we could do it immediately but the additional code is not worth the lost microtask.
+	user_effect(() => {
+		var value = get_value();
 
-	/** @type {import('#client').Effect | undefined} */
-	var render;
-	var destroyed = false;
-
-	var effect = managed_effect(() => {
-		destroy_effect(effect);
-
-		if (destroyed) return;
-
-		if (get_value() == null) {
-			callback();
+		// through isNaN we also allow number strings, which is more robust
+		if (!isNaN(/** @type {any} */ (value)) && value !== media.playbackRate) {
+			updating = true;
+			media.playbackRate = /** @type {number} */ (value);
 		}
 
-		listen(media, ['ratechange'], callback, false);
-
-		render = render_effect(() => {
-			var value = get_value();
-
-			// through isNaN we also allow number strings, which is more robust
-			if (!isNaN(/** @type {any} */ (value)) && value !== media.playbackRate) {
-				updating = true;
-				media.playbackRate = /** @type {number} */ (value);
-			}
+		listen(media, ['ratechange'], () => {
+			if (!updating) update(media.playbackRate);
+			updating = false;
 		});
 	});
-
-	render_effect(() => () => {
-		destroyed = true;
-		if (render) {
-			destroy_effect(render);
-		}
-	});
 }
 
 /**

packages/svelte/src/internal/client/reactivity/effects.js

@@ -128,22 +128,6 @@ export function effect(fn) {
 	return create_effect(EFFECT, fn, false);
 }
 
-/**
- * @param {() => void | (() => void)} fn
- * @returns {import('#client').Effect}
- */
-export function managed_effect(fn) {
-	return create_effect(EFFECT | MANAGED, fn, false);
-}
-
-/**
- * @param {() => void | (() => void)} fn
- * @returns {import('#client').Effect}
- */
-export function managed_pre_effect(fn) {
-	return create_effect(PRE_EFFECT | MANAGED, fn, false);
-}
-
 /**
  * Internal representation of `$effect.pre(...)`
  * @param {() => void | (() => void)} fn

playgrounds/demo/src/entry-client.ts

@@ -1,8 +1,8 @@
 // @ts-ignore
-import { hydrate, unmount } from 'svelte';
+import { mount, unmount } from 'svelte';
 // @ts-ignore you need to create this file
 import App from './App.svelte';
-const component = hydrate(App, {
+const component = mount(App, {
 	target: document.getElementById('root')!
 });
 // @ts-ignore