Skip to content

Commit 868e3fa

Browse files
committed
chore: fix $props.id tests
1 parent b6bf735 commit 868e3fa

File tree

2 files changed

+15
-49
lines changed

2 files changed

+15
-49
lines changed

packages/svelte/tests/runtime-runes/samples/props-id/_config.js

Lines changed: 14 additions & 48 deletions
Original file line numberDiff line numberDiff line change
@@ -3,59 +3,25 @@ import { test } from '../../test';
33

44
export default test({
55
test({ assert, target, variant }) {
6-
if (variant === 'dom') {
7-
assert.htmlEqual(
8-
target.innerHTML,
9-
`
10-
<button>toggle</button>
11-
<h1>c1</h1>
12-
<p>c2</p>
13-
<p>c3</p>
14-
<p>c4</p>
15-
`
16-
);
17-
} else {
18-
assert.htmlEqual(
19-
target.innerHTML,
20-
`
21-
<button>toggle</button>
22-
<h1>s1</h1>
23-
<p>s2</p>
24-
<p>s3</p>
25-
<p>s4</p>
26-
`
27-
);
6+
const ps = [...target.querySelectorAll('p')].map((p) => p.innerHTML);
7+
const unique = new Set(ps);
8+
assert.equal(ps.length, unique.size);
9+
10+
if (variant === 'hydrate') {
11+
const start = ps.map((p) => p.substring(0, 1));
12+
assert.deepEqual(start, ['s', 's', 's', 's']);
2813
}
2914

3015
let button = target.querySelector('button');
3116
flushSync(() => button?.click());
3217

33-
if (variant === 'dom') {
34-
assert.htmlEqual(
35-
target.innerHTML,
36-
`
37-
<button>toggle</button>
38-
<h1>c1</h1>
39-
<p>c2</p>
40-
<p>c3</p>
41-
<p>c4</p>
42-
<p>c5</p>
43-
`
44-
);
45-
} else {
46-
// `c6` because this runs after the `dom` tests
47-
// (slightly brittle but good enough for now)
48-
assert.htmlEqual(
49-
target.innerHTML,
50-
`
51-
<button>toggle</button>
52-
<h1>s1</h1>
53-
<p>s2</p>
54-
<p>s3</p>
55-
<p>s4</p>
56-
<p>c6</p>
57-
`
58-
);
18+
const ps_after = [...target.querySelectorAll('p')].map((p) => p.innerHTML);
19+
const unique_after = new Set(ps_after);
20+
assert.equal(ps_after.length, unique_after.size);
21+
22+
if (variant === 'hydrate') {
23+
const start = ps_after.map((p) => p.substring(0, 1));
24+
assert.deepEqual(start, ['s', 's', 's', 's', 'c']);
5925
}
6026
}
6127
});

packages/svelte/tests/runtime-runes/samples/props-id/main.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
<button onclick={() => show = !show}>toggle</button>
1010

11-
<h1>{id}</h1>
11+
<p>{id}</p>
1212

1313
<Child />
1414
<Child />

0 commit comments

Comments
 (0)