ignore control characters following a svelte-ignore comment

Author: Rich-Harris

packages/svelte/src/compiler/phases/2-analyze/visitors/Text.js

@@ -4,15 +4,20 @@ import { is_tag_valid_with_parent } from '../../../../html-tree-validation.js';
 import { regex_bidirectional_control_characters, regex_not_whitespace } from '../../patterns.js';
 import * as e from '../../../errors.js';
 import * as w from '../../../warnings.js';
+import { extract_svelte_ignore } from '../../../utils/extract_svelte_ignore.js';
 
 /**
  * @param {AST.Text} node
  * @param {Context} context
  */
 export function Text(node, context) {
-	const in_template = context.path.at(-1)?.type === 'Fragment';
+	const parent = /** @type {AST.SvelteNode} */ (context.path.at(-1));
 
-	if (in_template && context.state.parent_element && regex_not_whitespace.test(node.data)) {
+	if (
+		parent.type === 'Fragment' &&
+		context.state.parent_element &&
+		regex_not_whitespace.test(node.data)
+	) {
 		const message = is_tag_valid_with_parent('#text', context.state.parent_element);
 		if (message) {
 			e.node_invalid_placement(node, message);
@@ -21,7 +26,27 @@ export function Text(node, context) {
 
 	regex_bidirectional_control_characters.lastIndex = 0;
 	for (const match of node.data.matchAll(regex_bidirectional_control_characters)) {
-		let start = match.index + node.start;
-		w.bidirectional_control_characters({ start, end: start + match[0].length });
+		let is_ignored = false;
+
+		// if we have a svelte-ignore comment earlier in the text, bail
+		// (otherwise we can only use svelte-ignore on parent elements/blocks)
+		if (parent.type === 'Fragment') {
+			for (const child of parent.nodes) {
+				if (child === node) break;
+
+				if (child.type === 'Comment') {
+					is_ignored ||= extract_svelte_ignore(
+						child.start + 4,
+						child.data,
+						context.state.analysis.runes
+					).includes('bidirectional_control_characters');
+				}
+			}
+		}
+
+		if (!is_ignored) {
+			let start = match.index + node.start;
+			w.bidirectional_control_characters({ start, end: start + match[0].length });
+		}
 	}
 }

packages/svelte/tests/validator/samples/bidirectional-control-characters/input.svelte

@@ -5,4 +5,4 @@
 <h1>Hello, {name}!</h1>
 
 <!-- svelte-ignore bidirectional_control_characters -->
-<div>⁧⁦def⁩⁦abc⁩⁩</div>
+⁧⁦def⁩⁦abc⁩⁩