fix: avoid throwing store_invalid_subscription_module for runes (#12848)

* fix: avoid throwing `store_invalid_subscription_module` for runes

Co-authored-by: Paolo Ricciuti <[email protected]>

* move test to the validator suite, which is faster

---------

Co-authored-by: Paolo Ricciuti <[email protected]>
Co-authored-by: Rich Harris <[email protected]>

Author: 3 people

.changeset/funny-bugs-kiss.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: avoid throwing `store_invalid_subscription_module` for runes

packages/svelte/src/compiler/phases/2-analyze/index.js

@@ -223,7 +223,7 @@ export function analyze_module(ast, options) {
 
 		const binding = scope.get(name.slice(1));
 
-		if (binding !== null) {
+		if (binding !== null && !is_rune(name)) {
 			e.store_invalid_subscription_module(references[0].node);
 		}
 	}

packages/svelte/tests/validator/samples/runes-conflicting-store-in-module/_config.js

@@ -0,0 +1,3 @@
+import { test } from '../../test';
+
+export default test({});

packages/svelte/tests/validator/samples/runes-conflicting-store-in-module/input.svelte.js

@@ -0,0 +1,14 @@
+const state = $state(0);
+
+const derived = $derived(state + 2);
+
+let effect = {};
+let inspect = {};
+
+$effect.root(() => {
+	$inspect(state);
+
+	$effect(() => {
+		console.log(state);
+	});
+});

packages/svelte/tests/validator/test.ts

@@ -1,6 +1,6 @@
 import * as fs from 'node:fs';
 import { it, assert } from 'vitest';
-import { compile } from 'svelte/compiler';
+import { compile, compileModule } from 'svelte/compiler';
 import { try_load_json } from '../helpers.js';
 import { suite, type BaseTest } from '../suite.js';
 import type { CompileError } from '#compiler';
@@ -14,19 +14,24 @@ interface ValidatorTest extends BaseTest {
 }
 
 const { test, run } = suite<ValidatorTest>(async (config, cwd) => {
-	const input = fs
-		.readFileSync(`${cwd}/input.svelte`, 'utf-8')
-		.replace(/\s+$/, '')
-		.replace(/\r/g, '');
-
 	const expected_warnings = try_load_json(`${cwd}/warnings.json`) || [];
 	const expected_errors = try_load_json(`${cwd}/errors.json`);
 	const options = try_load_json(`${cwd}/options.json`);
 
 	let error;
 
 	try {
-		const { warnings } = compile(input, {
+		const module = fs.existsSync(`${cwd}/input.svelte.js`);
+
+		const input = (
+			module
+				? fs.readFileSync(`${cwd}/input.svelte.js`, 'utf-8')
+				: fs.readFileSync(`${cwd}/input.svelte`, 'utf-8')
+		)
+			.replace(/\s+$/, '')
+			.replace(/\r/g, '');
+
+		const { warnings } = (module ? compileModule : compile)(input, {
 			...config.compileOptions,
 			generate: false,
 			...options