show ranges during parsing, and warn on all occurrences rather than just the first

Author: Rich-Harris

packages/svelte/src/compiler/phases/1-parse/index.js

@@ -65,9 +65,10 @@ export class Parser {
 			throw new TypeError('Template must be a string');
 		}
 
-		const control_chars = regex_bidirectional_control_characters.exec(template);
-		if (control_chars) {
-			w.bidirectional_control_characters({ start: template.indexOf(control_chars[0][0]) });
+		regex_bidirectional_control_characters.lastIndex = 0;
+		for (const match of template.matchAll(regex_bidirectional_control_characters)) {
+			let start = match.index;
+			w.bidirectional_control_characters({ start, end: start + match[0].length });
 		}
 
 		this.loose = loose;

packages/svelte/src/compiler/phases/patterns.js

@@ -22,4 +22,4 @@ export const regex_starts_with_vowel = /^[aeiou]/;
 export const regex_heading_tags = /^h[1-6]$/;
 export const regex_illegal_attribute_character = /(^[0-9-.])|[\^$@%&#?!|()[\]{}^*+~;]/;
 export const regex_bidirectional_control_characters =
-	/[\u202a\u202b\u202c\u202d\u202e\u2066\u2067\u2068\u2069]/;
+	/[\u202a\u202b\u202c\u202d\u202e\u2066\u2067\u2068\u2069]+/g;

packages/svelte/tests/validator/samples/bidirectional-control-characters/warnings.json

@@ -8,7 +8,31 @@
 		},
 		"end": {
 			"line": 4,
-			"column": 0
+			"column": 2
+		}
+	},
+	{
+		"code": "bidirectional_control_characters",
+		"message": "A bidirectional control character was detected in your code. These characters can be used to alter the visual direction of your code and could have unintended consequences",
+		"start": {
+			"line": 4,
+			"column": 5
+		},
+		"end": {
+			"line": 4,
+			"column": 7
+		}
+	},
+	{
+		"code": "bidirectional_control_characters",
+		"message": "A bidirectional control character was detected in your code. These characters can be used to alter the visual direction of your code and could have unintended consequences",
+		"start": {
+			"line": 4,
+			"column": 10
+		},
+		"end": {
+			"line": 4,
+			"column": 12
 		}
 	},
 	{