Skip to content

Commit 926f9a5

Browse files
committed
replace 'group' binding with , drive-by fix some other messages
1 parent d2e2021 commit 926f9a5

File tree

7 files changed

+10
-10
lines changed

7 files changed

+10
-10
lines changed

packages/svelte/src/compiler/phases/2-analyze/visitors/BindDirective.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ export function BindDirective(node, context) {
3333
e.bind_invalid_target(
3434
node,
3535
node.name,
36-
property.valid_elements.map((valid_element) => `<${valid_element}>`).join(', ')
36+
property.valid_elements.map((valid_element) => `\`<${valid_element}>\``).join(', ')
3737
);
3838
}
3939

@@ -70,12 +70,12 @@ export function BindDirective(node, context) {
7070
e.bind_invalid_target(
7171
node,
7272
node.name,
73-
`<input type="checkbox">${type?.value[0].data === 'radio' ? ` — for <input type="radio">, use 'group' binding` : ''}`
73+
`\`<input type="checkbox">\`${type?.value[0].data === 'radio' ? ` — for \`<input type="radio">\`, use \`bind:group\`` : ''}`
7474
);
7575
}
7676

7777
if (node.name === 'files' && type?.value[0].data !== 'file') {
78-
e.bind_invalid_target(node, node.name, '<input type="file">');
78+
e.bind_invalid_target(node, node.name, '`<input type="file">`');
7979
}
8080
}
8181
}
@@ -98,7 +98,7 @@ export function BindDirective(node, context) {
9898
e.bind_invalid_target(
9999
node,
100100
node.name,
101-
`non-<svg> elements. Use 'clientWidth' for <svg> instead`
101+
`non-\`<svg>\` elements. Use \`bind:clientWidth\` for \`<svg>\` instead`
102102
);
103103
}
104104

packages/svelte/tests/compiler-errors/samples/dynamic-element-binding-invalid/_config.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,6 @@ import { test } from '../../test';
33
export default test({
44
error: {
55
code: 'bind_invalid_target',
6-
message: '`bind:value` can only be used with <input>, <textarea>, <select>'
6+
message: '`bind:value` can only be used with `<input>`, `<textarea>`, `<select>`'
77
}
88
});

packages/svelte/tests/validator/samples/binding-dimensions-svg/errors.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[
22
{
33
"code": "bind_invalid_target",
4-
"message": "`bind:offsetWidth` can only be used with non-<svg> elements. Use 'clientWidth' for <svg> instead",
4+
"message": "`bind:offsetWidth` can only be used with non-`<svg>` elements. Use `bind:clientWidth` for `<svg>` instead",
55
"start": {
66
"line": 5,
77
"column": 5

packages/svelte/tests/validator/samples/binding-input-checked/errors.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[
22
{
33
"code": "bind_invalid_target",
4-
"message": "`bind:checked` can only be used with <input type=\"checkbox\">",
4+
"message": "`bind:checked` can only be used with `<input type=\"checkbox\">`",
55
"start": {
66
"line": 5,
77
"column": 7

packages/svelte/tests/validator/samples/binding-invalid-on-element-2/errors.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[
22
{
33
"code": "bind_invalid_target",
4-
"message": "`bind:open` can only be used with <details>",
4+
"message": "`bind:open` can only be used with `<details>`",
55
"start": {
66
"line": 5,
77
"column": 5

packages/svelte/tests/validator/samples/binding-invalid-on-element/errors.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[
22
{
33
"code": "bind_invalid_target",
4-
"message": "`bind:value` can only be used with <input>, <textarea>, <select>",
4+
"message": "`bind:value` can only be used with `<input>`, `<textarea>`, `<select>`",
55
"start": {
66
"line": 5,
77
"column": 5

packages/svelte/tests/validator/samples/binding-radio-input-checked/errors.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[
22
{
33
"code": "bind_invalid_target",
4-
"message": "`bind:checked` can only be used with <input type=\"checkbox\"> — for <input type=\"radio\">, use 'group' binding",
4+
"message": "`bind:checked` can only be used with `<input type=\"checkbox\">` — for `<input type=\"radio\">`, use `bind:group`",
55
"start": {
66
"line": 5,
77
"column": 20

0 commit comments

Comments
 (0)