fix: remove memory leak, make beforeUpdate etc work correctly (#10570)

* fix: remove memory leak

* changeset

* mutable_source is only used in non-runes mode, no need to check here

* simplify

* oops

---------

Co-authored-by: Rich Harris <[email protected]>

Author: Rich-Harris

.changeset/kind-dots-sort.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: remove memory leak

.changeset/real-pandas-brush.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: call beforeUpdate/afterUpdate callbacks when props are mutated

packages/svelte/src/internal/client/runtime.js

@@ -1308,7 +1308,6 @@ export function derived(init) {
 		create_computation_signal(flags | CLEAN, UNINITIALIZED, current_block)
 	);
 	signal.i = init;
-	bind_signal_to_component_context(signal);
 	signal.e = default_equals;
 	if (current_consumer !== null) {
 		push_reference(current_consumer, signal);
@@ -1335,26 +1334,7 @@ export function derived_safe_equal(init) {
  */
 /*#__NO_SIDE_EFFECTS__*/
 export function source(initial_value) {
-	const source = create_source_signal(SOURCE | CLEAN, initial_value);
-	bind_signal_to_component_context(source);
-	return source;
-}
-
-/**
- * This function binds a signal to the component context, so that we can fire
- * beforeUpdate/afterUpdate callbacks at the correct time etc
- * @param {import('./types.js').Signal} signal
- */
-function bind_signal_to_component_context(signal) {
-	if (current_component_context === null || !current_component_context.r) return;
-
-	const signals = current_component_context.d;
-
-	if (signals) {
-		signals.push(signal);
-	} else {
-		current_component_context.d = [signal];
-	}
+	return create_source_signal(SOURCE | CLEAN, initial_value);
 }
 
 /**
@@ -1366,6 +1346,13 @@ function bind_signal_to_component_context(signal) {
 export function mutable_source(initial_value) {
 	const s = source(initial_value);
 	s.e = safe_equal;
+
+	// bind the signal to the component context, in case we need to
+	// track updates to trigger beforeUpdate/afterUpdate callbacks
+	if (current_component_context) {
+		(current_component_context.d ??= []).push(s);
+	}
+
 	return s;
 }
 
@@ -1974,10 +1961,7 @@ function observe_all(context) {
 		for (const signal of context.d) get(signal);
 	}
 
-	const props = get_descriptors(context.s);
-	for (const descriptor of Object.values(props)) {
-		if (descriptor.get) descriptor.get();
-	}
+	deep_read(context.s);
 }
 
 /**

packages/svelte/tests/runtime-runes/samples/before-update-in-legacy-child/Child.svelte

@@ -0,0 +1,12 @@
+<svelte:options runes={false} />
+
+<script>
+	import { beforeUpdate } from 'svelte';
+	import { logs } from './logs.js'
+
+	export let object;
+
+	beforeUpdate(() => {
+		logs.push('changed');
+	});
+</script>

packages/svelte/tests/runtime-runes/samples/before-update-in-legacy-child/_config.js

@@ -0,0 +1,20 @@
+import { flushSync } from 'svelte';
+import { test } from '../../test';
+import { logs } from './logs.js';
+
+export default test({
+	html: `<button>clicks: 0</button>`,
+
+	test({ assert, target }) {
+		const btn = target.querySelector('button');
+
+		flushSync(() => btn?.click());
+
+		assert.htmlEqual(target.innerHTML, `<button>clicks: 1</button>`);
+		assert.deepEqual(logs, ['changed', 'changed']);
+	},
+
+	after_test() {
+		logs.length = 0;
+	}
+});

packages/svelte/tests/runtime-runes/samples/before-update-in-legacy-child/logs.js

@@ -0,0 +1,2 @@
+/** @type {any[]} */
+export const logs = [];

packages/svelte/tests/runtime-runes/samples/before-update-in-legacy-child/main.svelte

@@ -0,0 +1,10 @@
+<script>
+	import Child from './Child.svelte';
+	let object = $state({ count: 0 })
+</script>
+
+<button onclick={() => object.count += 1}>
+	clicks: {object.count}
+</button>
+
+<Child {object} />