handle prop aliases

Author: Rich-Harris

documentation/docs/98-reference/.generated/client-warnings.md

@@ -171,7 +171,7 @@ To fix it, `bind:` to the value instead of just passing a property (i.e. in this
 ### ownership_invalid_mutation
 
 ```
-%component% mutated property `%prop%` from parent component %owner%, which did not declare it as a binding. This is strongly discouraged. Consider passing props to child components that mutate them with `bind:` (e.g. `bind:%prop%={...}` instead of `%prop%={...}`), or use a callback instead
+%component% mutated property `%name%` from parent component %owner%, which did not declare it as a binding. This is strongly discouraged. Consider passing props to child components that mutate them with `bind:` (e.g. `bind:%prop%={...}` instead of `%prop%={...}`), or use a callback instead
 ```
 
 Consider the following code:

packages/svelte/messages/client-warnings/warnings.md

@@ -140,7 +140,7 @@ To fix it, `bind:` to the value instead of just passing a property (i.e. in this
 
 ## ownership_invalid_mutation
 
-> %component% mutated property `%prop%` from parent component %owner%, which did not declare it as a binding. This is strongly discouraged. Consider passing props to child components that mutate them with `bind:` (e.g. `bind:%prop%={...}` instead of `%prop%={...}`), or use a callback instead
+> %component% mutated property `%name%` from parent component %owner%, which did not declare it as a binding. This is strongly discouraged. Consider passing props to child components that mutate them with `bind:` (e.g. `bind:%prop%={...}` instead of `%prop%={...}`), or use a callback instead
 
 Consider the following code:
 

packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/utils.js

@@ -341,5 +341,10 @@ export function validate_mutation(node, context, expression) {
 
 	path.unshift(b.literal(name.name));
 
-	return b.call('$$ownership_validator.mutation', b.array(path), expression);
+	return b.call(
+		'$$ownership_validator.mutation',
+		b.literal(binding.prop_alias),
+		b.array(path),
+		expression
+	);
 }

packages/svelte/src/internal/client/dev/ownership.js

@@ -115,25 +115,26 @@ export function create_ownership_validator(props) {
 
 	return {
 		/**
+		 * @param {string} prop
 		 * @param {any[]} path
 		 * @param {any} result
 		 */
-		mutation: (path, result) => {
-			const prop_name = path[0];
-			if (is_bound(props, prop_name) || !parent) {
+		mutation: (prop, path, result) => {
+			const name = path[0];
+			if (is_bound(props, name) || !parent) {
 				return result;
 			}
 
-			let prop = props[prop_name];
+			let value = props[name];
 
 			for (let i = 1; i < path.length - 1; i++) {
-				if (!prop?.[STATE_SYMBOL]) {
+				if (!value?.[STATE_SYMBOL]) {
 					return result;
 				}
-				prop = prop[path[i]];
+				value = value[path[i]];
 			}
 
-			w.ownership_invalid_mutation(component[FILENAME], prop_name, parent[FILENAME]);
+			w.ownership_invalid_mutation(component[FILENAME], name, parent[FILENAME], prop);
 
 			return result;
 		},

packages/svelte/src/internal/client/warnings.js

@@ -144,14 +144,15 @@ export function ownership_invalid_binding(parent, prop, child, owner) {
 }
 
 /**
- * %component% mutated property `%prop%` from parent component %owner%, which did not declare it as a binding. This is strongly discouraged. Consider passing props to child components that mutate them with `bind:` (e.g. `bind:%prop%={...}` instead of `%prop%={...}`), or use a callback instead
+ * %component% mutated property `%name%` from parent component %owner%, which did not declare it as a binding. This is strongly discouraged. Consider passing props to child components that mutate them with `bind:` (e.g. `bind:%prop%={...}` instead of `%prop%={...}`), or use a callback instead
  * @param {string} component
- * @param {string} prop
+ * @param {string} name
  * @param {string} owner
+ * @param {string} prop
  */
-export function ownership_invalid_mutation(component, prop, owner) {
+export function ownership_invalid_mutation(component, name, owner, prop) {
 	if (DEV) {
-		console.warn(`%c[svelte] ownership_invalid_mutation\n%c${component} mutated property \`${prop}\` from parent component ${owner}, which did not declare it as a binding. This is strongly discouraged. Consider passing props to child components that mutate them with \`bind:\` (e.g. \`bind:${prop}={...}\` instead of \`${prop}={...}\`), or use a callback instead\nhttps://svelte.dev/e/ownership_invalid_mutation`, bold, normal);
+		console.warn(`%c[svelte] ownership_invalid_mutation\n%c${component} mutated property \`${name}\` from parent component ${owner}, which did not declare it as a binding. This is strongly discouraged. Consider passing props to child components that mutate them with \`bind:\` (e.g. \`bind:${prop}={...}\` instead of \`${prop}={...}\`), or use a callback instead\nhttps://svelte.dev/e/ownership_invalid_mutation`, bold, normal);
 	} else {
 		console.warn(`https://svelte.dev/e/ownership_invalid_mutation`);
 	}