fix: moving deriveds during migration deletes part of the inserted code

Author: paoloricciuti

.changeset/cool-apes-confess.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: moving deriveds during migration deletes part of the inserted code

packages/svelte/src/compiler/migrate/index.js

@@ -273,7 +273,12 @@ export function migrate(source, { filename } = {}) {
 				const { start, end } = get_node_range(source, node);
 				str.appendLeft(end, '\n');
 				str.move(start, end, /** @type {number} */ (parsed.instance?.content.end));
-				str.remove(start - (source[start - 2] === '\r' ? 2 : 1), start);
+				const carriage_idx = start - (source[start - 2] === '\r' ? 2 : 1);
+				// we might end up injecting something at the position we are about to remove
+				// since we only want to remove the carriage if we add the trimmed length
+				// of the transformed string to prevent removing something we added.
+				const transformed = state.str.snip(carriage_idx, start).toString().trim();
+				str.remove(carriage_idx + transformed.length, start);
 			}
 		}
 

packages/svelte/tests/migrate/samples/reactive-statements-reorder-not-deleting-additions/input.svelte

@@ -0,0 +1,12 @@
+<script>
+	export let data
+	$: ({ foo } = data)
+
+	import { blah } from './blah.js'
+
+	let bar
+	$: {
+		bar = []
+		let baz
+	}
+</script>

packages/svelte/tests/migrate/samples/reactive-statements-reorder-not-deleting-additions/output.svelte

@@ -0,0 +1,16 @@
+<script>
+	import { run } from 'svelte/legacy';
+
+
+	import { blah } from './blah.js'
+	/** @type {{data: any}} */
+	let { data } = $props();
+
+	let bar = $state()
+
+	let { foo } = $derived(data)
+	run(() => {
+		bar = []
+		let baz
+	});
+</script>