chore: improve set_text perf (#12823)

trueadm · web-flow · commit adcceb4acaec · 2024-08-13T10:43:14.000-04:00
* chore: improve set_text perf

* chore: improve set_text perf

* chore: improve set_text perf

* chore: improve set_text perf
diff --git a/packages/svelte/src/internal/client/render.js b/packages/svelte/src/internal/client/render.js
@@ -47,7 +47,9 @@ export function set_text(text, value) {
 
 	if (prev !== value) {
 		// @ts-expect-error
-		text.nodeValue = text.__t = value;
+		text.__t = value;
+		// It's faster to make the value a string rather than passing a non-string to nodeValue
+		text.nodeValue = value == null ? '' : value + '';
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,9 @@ export function set_text(text, value) {`
`47`	`47`
`48`	`48`	`if (prev !== value) {`
`49`	`49`	`// @ts-expect-error`
`50`		`- text.nodeValue = text.__t = value;`
	`50`	`+ text.__t = value;`
	`51`	`+ // It's faster to make the value a string rather than passing a non-string to nodeValue`
	`52`	`+ text.nodeValue = value == null ? '' : value + '';`
`51`	`53`	`}`
`52`	`54`	`}`
`53`	`55`