Skip to content

Commit b41300d

Browse files
ssssotaRich-Harris
andauthored
fix: improve createRawSnippet types with cleanup type (#12894)
* fix: improve createRawSnippet types Add cleanup type to return value of setup function * changeset --------- Co-authored-by: Rich Harris <[email protected]>
1 parent 7eabce8 commit b41300d

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

.changeset/nasty-penguins-pump.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"svelte": patch
3+
---
4+
5+
fix: add cleanup function signature to `createRawSnippet`

packages/svelte/src/internal/client/dom/blocks/snippet.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ export function wrap_snippet(component, fn) {
7272
* @template {unknown[]} Params
7373
* @param {(...params: Getters<Params>) => {
7474
* render: () => string
75-
* setup?: (element: Element) => void
75+
* setup?: (element: Element) => void | (() => void)
7676
* }} fn
7777
* @returns {Snippet<Params>}
7878
*/

packages/svelte/src/internal/server/blocks/snippet.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @template {unknown[]} Params
88
* @param {(...params: Getters<Params>) => {
99
* render: () => string
10-
* setup?: (element: Element) => void
10+
* setup?: (element: Element) => void | (() => void)
1111
* }} fn
1212
* @returns {Snippet<Params>}
1313
*/

packages/svelte/types/index.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -378,7 +378,7 @@ declare module 'svelte' {
378378
* */
379379
export function createRawSnippet<Params extends unknown[]>(fn: (...params: Getters<Params>) => {
380380
render: () => string;
381-
setup?: (element: Element) => void;
381+
setup?: (element: Element) => void | (() => void);
382382
}): Snippet<Params>;
383383
/** Anything except a function */
384384
type NotFunction<T> = T extends Function ? never : T;

0 commit comments

Comments
 (0)