Skip to content

Commit b7a0d80

Browse files
authored
simplify render_effect signature (#10925)
* simplify render_effect signature * lint
1 parent 59ff650 commit b7a0d80

File tree

4 files changed

+21
-33
lines changed

4 files changed

+21
-33
lines changed

packages/svelte/src/internal/client/dom/blocks/key.js

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,15 @@ export function key_block(anchor, get_key, render_fn) {
3636
});
3737
}
3838

39-
effect = render_effect(
40-
() => {
41-
const dom = render_fn(anchor);
42-
43-
return () => {
44-
if (dom !== undefined) {
45-
remove(dom);
46-
}
47-
};
48-
},
49-
true,
50-
true
51-
);
39+
effect = render_effect(() => {
40+
const dom = render_fn(anchor);
41+
42+
return () => {
43+
if (dom !== undefined) {
44+
remove(dom);
45+
}
46+
};
47+
}, true);
5248

5349
effects.add(effect);
5450
}

packages/svelte/src/internal/client/dom/elements/misc.js

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { hydrating } from '../hydration.js';
2-
import { render_effect } from '../../reactivity/effects.js';
2+
import { user_effect } from '../../reactivity/effects.js';
33

44
/**
55
* @param {HTMLElement} dom
@@ -10,15 +10,12 @@ export function autofocus(dom, value) {
1010
if (value) {
1111
const body = document.body;
1212
dom.autofocus = true;
13-
render_effect(
14-
() => {
15-
if (document.activeElement === body) {
16-
dom.focus();
17-
}
18-
},
19-
true,
20-
false
21-
);
13+
14+
user_effect(() => {
15+
if (document.activeElement === body) {
16+
dom.focus();
17+
}
18+
});
2219
}
2320
}
2421

packages/svelte/src/internal/client/reactivity/effects.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -216,14 +216,13 @@ export function invalidate_effect(fn) {
216216
/**
217217
* @param {(() => void)} fn
218218
* @param {boolean} managed
219-
* @param {boolean} sync
220219
* @returns {import('#client').Effect}
221220
*/
222-
export function render_effect(fn, managed = false, sync = true) {
221+
export function render_effect(fn, managed = false) {
223222
let flags = RENDER_EFFECT;
224223
if (managed) flags |= MANAGED;
225224

226-
return create_effect(flags, /** @type {any} */ (fn), sync);
225+
return create_effect(flags, /** @type {any} */ (fn), true);
227226
}
228227

229228
/**

packages/svelte/tests/signals/test.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,9 @@ function run_test(runes: boolean, fn: (runes: boolean) => () => void) {
2222
$.push({}, runes);
2323
// Create a render context so that effect validations etc don't fail
2424
let execute: any;
25-
const signal = render_effect(
26-
() => {
27-
execute = fn(runes);
28-
},
29-
true,
30-
true
31-
);
25+
const signal = render_effect(() => {
26+
execute = fn(runes);
27+
}, true);
3228
$.pop();
3329
execute();
3430
destroy_effect(signal);

0 commit comments

Comments
 (0)