fix timing

Rich-Harris · Rich-Harris · commit c270c7677916 · 2025-01-31T06:02:10.000-05:00
diff --git a/packages/svelte/src/internal/client/dom/blocks/boundary.js b/packages/svelte/src/internal/client/dom/blocks/boundary.js
@@ -169,8 +169,6 @@ export function boundary(node, props, children) {
 				offscreen_fragment = null;
 			}
 
-			// TODO this timing is wrong, effects need to ~somehow~ end up
-			// in the right place
 			for (const e of effects) {
 				try {
 					if (check_dirtiness(e)) {
@@ -217,7 +215,7 @@ export function boundary(node, props, children) {
 			}
 
 			if (input === ADD_EFFECT) {
-				render_effects.push(payload);
+				effects.push(payload);
 				return;
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -169,8 +169,6 @@ export function boundary(node, props, children) {`
`169`	`169`	`offscreen_fragment = null;`
`170`	`170`	`}`
`171`	`171`
`172`		`- // TODO this timing is wrong, effects need to ~somehow~ end up`
`173`		`- // in the right place`
`174`	`172`	`for (const e of effects) {`
`175`	`173`	`try {`
`176`	`174`	`if (check_dirtiness(e)) {`
`@@ -217,7 +215,7 @@ export function boundary(node, props, children) {`
`217`	`215`	`}`
`218`	`216`
`219`	`217`	`if (input === ADD_EFFECT) {`
`220`		`- render_effects.push(payload);`
	`218`	`+ effects.push(payload);`
`221`	`219`	`return;`
`222`	`220`	`}`
`223`	`221`