Skip to content

Commit d124a93

Browse files
committed
chore: provide links to documentation for errors/warnings
closes #11305
1 parent c1c59e7 commit d124a93

File tree

15 files changed

+350
-372
lines changed

15 files changed

+350
-372
lines changed

packages/svelte/scripts/process-messages/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,10 +355,11 @@ function transform(name, dest) {
355355
}
356356

357357
if (message.type === 'TemplateLiteral') {
358-
quasi.value.raw += message.quasis[0].value.raw + q.value.raw;
358+
quasi.value.raw += message.quasis[0].value.raw;
359359
out.quasis.push(...message.quasis.slice(1));
360360
out.expressions.push(...message.expressions);
361361
quasi = message.quasis[message.quasis.length - 1];
362+
quasi.value.raw += q.value.raw;
362363
continue;
363364
}
364365
}

packages/svelte/scripts/process-messages/templates/client-errors.js

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,12 @@ import { DEV } from 'esm-env';
77
*/
88
export function CODE(PARAMETER) {
99
if (DEV) {
10-
const error = new Error(`${'CODE'}\n${MESSAGE}`);
10+
const error = new Error(
11+
`${'CODE'}\n${MESSAGE}\nSee https://svelte.dev/e/${'CODE'} for more info`
12+
);
1113
error.name = 'Svelte error';
1214
throw error;
1315
} else {
14-
// TODO print a link to the documentation
15-
throw new Error('CODE');
16+
throw new Error(`${'CODE'} (https://svelte.dev/e/${'CODE'})`);
1617
}
1718
}

packages/svelte/scripts/process-messages/templates/client-warnings.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,12 @@ var normal = 'font-weight: normal';
99
*/
1010
export function CODE(PARAMETER) {
1111
if (DEV) {
12-
console.warn(`%c[svelte] ${'CODE'}\n%c${MESSAGE}`, bold, normal);
12+
console.warn(
13+
`%c[svelte] ${'CODE'}\n%c${MESSAGE}\nSee https://svelte.dev/e/${'CODE'} for more info`,
14+
bold,
15+
normal
16+
);
1317
} else {
14-
// TODO print a link to the documentation
15-
console.warn('CODE');
18+
console.warn(`${'CODE'} (https://svelte.dev/e/${'CODE'})`);
1619
}
1720
}

packages/svelte/scripts/process-messages/templates/compile-errors.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,5 +56,5 @@ function e(node, code, message) {
5656
* @returns {never}
5757
*/
5858
export function CODE(node, PARAMETER) {
59-
e(node, 'CODE', MESSAGE);
59+
e(node, 'CODE', `${MESSAGE}\nSee https://svelte.dev/e/${'CODE'} for more info`);
6060
}

packages/svelte/scripts/process-messages/templates/compile-warnings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,5 +47,5 @@ export const codes = CODES;
4747
* @param {string} PARAMETER
4848
*/
4949
export function CODE(node, PARAMETER) {
50-
w(node, 'CODE', MESSAGE);
50+
w(node, 'CODE', `${MESSAGE}\nSee https://svelte.dev/e/${'CODE'} for more info`);
5151
}

packages/svelte/scripts/process-messages/templates/server-errors.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,9 @@
44
* @returns {never}
55
*/
66
export function CODE(PARAMETER) {
7-
const error = new Error(`${'CODE'}\n${MESSAGE}`);
7+
const error = new Error(
8+
`${'CODE'}\n${MESSAGE}\nSee https://svelte.dev/e/${'CODE'} for more info`
9+
);
810
error.name = 'Svelte error';
911
throw error;
1012
}

packages/svelte/scripts/process-messages/templates/shared-errors.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,13 @@ import { DEV } from 'esm-env';
77
*/
88
export function CODE(PARAMETER) {
99
if (DEV) {
10-
const error = new Error(`${'CODE'}\n${MESSAGE}`);
10+
const error = new Error(
11+
`${'CODE'}\n${MESSAGE}\nSee https://svelte.dev/e/${'CODE'} for more info`
12+
);
1113
error.name = 'Svelte error';
1214
throw error;
1315
} else {
1416
// TODO print a link to the documentation
15-
throw new Error('CODE');
17+
throw new Error(`${'CODE'} (https://svelte.dev/e/${'CODE'})`);
1618
}
1719
}

packages/svelte/scripts/process-messages/templates/shared-warnings.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,13 @@ var normal = 'font-weight: normal';
99
*/
1010
export function CODE(PARAMETER) {
1111
if (DEV) {
12-
console.warn(`%c[svelte] ${'CODE'}\n%c${MESSAGE}`, bold, normal);
12+
console.warn(
13+
`%c[svelte] ${'CODE'}\n%c${MESSAGE}\nSee https://svelte.dev/e/${'CODE'} for more info`,
14+
bold,
15+
normal
16+
);
1317
} else {
1418
// TODO print a link to the documentation
15-
console.warn('CODE');
19+
console.warn(`${'CODE'} (https://svelte.dev/e/${'CODE'})`);
1620
}
1721
}

0 commit comments

Comments
 (0)