Skip to content

Commit d137eca

Browse files
committed
adjust test
1 parent 13175b8 commit d137eca

File tree

1 file changed

+9
-15
lines changed
  • packages/svelte/tests/signals

1 file changed

+9
-15
lines changed

packages/svelte/tests/signals/test.ts

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import {
99
user_effect
1010
} from '../../src/internal/client/reactivity/effects';
1111
import { state, set, update, update_pre } from '../../src/internal/client/reactivity/sources';
12-
import type { Derived, Effect, Value } from '../../src/internal/client/types';
12+
import type { Derived, Effect, Source, Value } from '../../src/internal/client/types';
1313
import { proxy } from '../../src/internal/client/proxy';
1414
import { derived } from '../../src/internal/client/reactivity/deriveds';
1515
import { snapshot } from '../../src/internal/shared/clone.js';
@@ -518,7 +518,7 @@ describe('signals', () => {
518518
};
519519
});
520520

521-
test('schedules rerun when writing to signal before reading it', (runes) => {
521+
test.skip('schedules rerun when writing to signal before reading it', (runes) => {
522522
if (!runes) return () => {};
523523

524524
const error = console.error;
@@ -1023,10 +1023,12 @@ describe('signals', () => {
10231023

10241024
test('nested effects depend on state of upper effects', () => {
10251025
const logs: number[] = [];
1026+
let raw: Source<number>;
1027+
let proxied: { current: number };
10261028

10271029
user_effect(() => {
1028-
const raw = state(0);
1029-
const proxied = proxy({ current: 0 });
1030+
raw = state(0);
1031+
proxied = proxy({ current: 0 });
10301032

10311033
// We need those separate, else one working and rerunning the effect
10321034
// could mask the other one not rerunning
@@ -1037,20 +1039,12 @@ describe('signals', () => {
10371039
user_effect(() => {
10381040
logs.push(proxied.current);
10391041
});
1040-
1041-
// Important so that the updating effect is not running
1042-
// together with the reading effects
1043-
flushSync();
1044-
1045-
user_effect(() => {
1046-
$.untrack(() => {
1047-
set(raw, $.get(raw) + 1);
1048-
proxied.current += 1;
1049-
});
1050-
});
10511042
});
10521043

10531044
return () => {
1045+
flushSync();
1046+
set(raw, $.get(raw) + 1);
1047+
proxied.current += 1;
10541048
flushSync();
10551049
assert.deepEqual(logs, [0, 0, 1, 1]);
10561050
};

0 commit comments

Comments
 (0)