Skip to content

Commit db6545d

Browse files
trueadmRich-Harris
andauthored
fix: keep bound inputs in sync in runes mode (#13328)
* fix: keep bound inputs in sync in runes mode * small tweak, add more detailed explanatory comment --------- Co-authored-by: Rich Harris <[email protected]>
1 parent 00cc364 commit db6545d

File tree

4 files changed

+56
-1
lines changed

4 files changed

+56
-1
lines changed

.changeset/brown-pens-repeat.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'svelte': patch
3+
---
4+
5+
fix: keep bound inputs in sync in runes mode

packages/svelte/src/internal/client/dom/elements/bindings/input.js

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ import * as e from '../../../errors.js';
55
import { get_proxied_value, is } from '../../../proxy.js';
66
import { queue_micro_task } from '../../task.js';
77
import { hydrating } from '../../hydration.js';
8+
import { is_runes } from '../../../runtime.js';
89

910
/**
1011
* @param {HTMLInputElement} input
@@ -13,13 +14,24 @@ import { hydrating } from '../../hydration.js';
1314
* @returns {void}
1415
*/
1516
export function bind_value(input, get, set = get) {
17+
var runes = is_runes();
18+
1619
listen_to_event_and_reset_event(input, 'input', () => {
1720
if (DEV && input.type === 'checkbox') {
1821
// TODO should this happen in prod too?
1922
e.bind_invalid_checkbox_value();
2023
}
2124

22-
set(is_numberlike_input(input) ? to_number(input.value) : input.value);
25+
/** @type {unknown} */
26+
var value = is_numberlike_input(input) ? to_number(input.value) : input.value;
27+
set(value);
28+
29+
// In runes mode, respect any validation in accessors (doesn't apply in legacy mode,
30+
// because we use mutable state which ensures the render effect always runs)
31+
if (runes && value !== (value = get())) {
32+
// @ts-expect-error the value is coerced on assignment
33+
input.value = value ?? '';
34+
}
2335
});
2436

2537
render_effect(() => {
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
import { flushSync } from 'svelte';
2+
import { test } from '../../test';
3+
4+
export default test({
5+
html: `<input type="number"><div>0</div>`,
6+
mode: ['client', 'hydrate'],
7+
8+
async test({ assert, target }) {
9+
const [input1] = target.querySelectorAll('input');
10+
assert.equal(input1.value, '0');
11+
12+
input1.value = '1';
13+
input1.dispatchEvent(new window.InputEvent('input'));
14+
15+
flushSync();
16+
17+
assert.equal(input1.value, '1');
18+
assert.htmlEqual(target.innerHTML, `<input type="number"><div>1</div>`);
19+
20+
input1.value = '101';
21+
input1.dispatchEvent(new window.InputEvent('input'));
22+
flushSync();
23+
24+
assert.equal(input1.value, '100');
25+
assert.htmlEqual(target.innerHTML, `<input type="number"><div>100</div>`);
26+
}
27+
});
Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
<script>
2+
let v = $state(0)
3+
let count = {
4+
get v() { return v },
5+
set v(x) { {
6+
v = Math.min(100, +x)
7+
}},
8+
};
9+
</script>
10+
<input bind:value={count.v} type="number">
11+
<div>{count.v}</div>

0 commit comments

Comments
 (0)