Skip to content

Commit e2ba9ef

Browse files
committed
put equality statements first, it's faster
1 parent f8a43e1 commit e2ba9ef

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

packages/svelte/src/internal/client/reactivity/sources.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ export function set(source, value, should_proxy = false) {
140140
(!untracking || (active_reaction.f & INSPECT_EFFECT) !== 0) &&
141141
is_runes() &&
142142
(active_reaction.f & (DERIVED | BLOCK_EFFECT | INSPECT_EFFECT)) !== 0 &&
143-
!(source_ownership?.sources.includes(source) && source_ownership.reaction === active_reaction)
143+
!(source_ownership?.reaction === active_reaction && source_ownership.sources.includes(source))
144144
) {
145145
e.state_unsafe_mutation();
146146
}

packages/svelte/src/internal/client/runtime.js

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -235,8 +235,12 @@ function schedule_possible_effect_self_invalidation(signal, effect, root = true)
235235
for (var i = 0; i < reactions.length; i++) {
236236
var reaction = reactions[i];
237237

238-
if (source_ownership?.sources.includes(signal) && source_ownership.reaction === active_reaction)
238+
if (
239+
source_ownership?.reaction === active_reaction &&
240+
source_ownership.sources.includes(signal)
241+
) {
239242
continue;
243+
}
240244

241245
if ((reaction.f & DERIVED) !== 0) {
242246
schedule_possible_effect_self_invalidation(/** @type {Derived} */ (reaction), effect, false);
@@ -741,8 +745,8 @@ export function get(signal) {
741745
// Register the dependency on the current reaction signal.
742746
if (active_reaction !== null && !untracking) {
743747
if (
744-
!source_ownership?.sources.includes(signal) ||
745-
source_ownership.reaction !== active_reaction
748+
source_ownership?.reaction !== active_reaction ||
749+
!source_ownership?.sources.includes(signal)
746750
) {
747751
var deps = active_reaction.deps;
748752
if (signal.rv < read_version) {

0 commit comments

Comments
 (0)