chore: replace inline regex with variable (#16340)

* chore: replace inline regex with variable

* Update packages/svelte/src/compiler/phases/patterns.js

Co-authored-by: ComputerGuy <[email protected]>

* Update a11y.js

* Update a11y.js

---------

Co-authored-by: ComputerGuy <[email protected]>

Author: navorite

.changeset/tiny-news-whisper.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+chore: replace inline regex with variable

packages/svelte/src/compiler/phases/2-analyze/visitors/shared/a11y.js

@@ -6,7 +6,9 @@ import { roles as roles_map, aria, elementRoles } from 'aria-query';
 import { AXObjects, AXObjectRoles, elementAXObjects } from 'axobject-query';
 import {
 	regex_heading_tags,
+	regex_js_prefix,
 	regex_not_whitespace,
+	regex_redundant_img_alt,
 	regex_starts_with_vowel,
 	regex_whitespaces
 } from '../../../patterns.js';
@@ -1011,7 +1013,7 @@ export function check_element(node, context) {
 		if (href) {
 			const href_value = get_static_text_value(href);
 			if (href_value !== null) {
-				if (href_value === '' || href_value === '#' || /^\W*javascript:/i.test(href_value)) {
+				if (href_value === '' || href_value === '#' || regex_js_prefix.test(href_value)) {
 					w.a11y_invalid_attribute(href, href_value, href.name);
 				}
 			}
@@ -1061,7 +1063,7 @@ export function check_element(node, context) {
 		const alt_attribute = get_static_text_value(attribute_map.get('alt'));
 		const aria_hidden = get_static_value(attribute_map.get('aria-hidden'));
 		if (alt_attribute && !aria_hidden && !has_spread) {
-			if (/\b(image|picture|photo)\b/i.test(alt_attribute)) {
+			if (regex_redundant_img_alt.test(alt_attribute)) {
 				w.a11y_img_redundant_alt(node);
 			}
 		}

packages/svelte/src/compiler/phases/patterns.js

@@ -23,3 +23,5 @@ export const regex_heading_tags = /^h[1-6]$/;
 export const regex_illegal_attribute_character = /(^[0-9-.])|[\^$@%&#?!|()[\]{}^*+~;]/;
 export const regex_bidirectional_control_characters =
 	/[\u202a\u202b\u202c\u202d\u202e\u2066\u2067\u2068\u2069]+/g;
+export const regex_js_prefix = /^\W*javascript:/i;
+export const regex_redundant_img_alt = /\b(image|picture|photo)\b/i;