Skip to content

Commit ebf72be

Browse files
authored
chore: default remove_dom to false (#12267)
1 parent 5ce7599 commit ebf72be

File tree

2 files changed

+13
-13
lines changed

2 files changed

+13
-13
lines changed

packages/svelte/src/internal/client/reactivity/deriveds.js

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,16 @@ export function derived_safe_equal(fn) {
6363
}
6464

6565
/**
66-
* @param {import('#client').Derived} signal
66+
* @param {import('#client').Derived} derived
6767
* @returns {void}
6868
*/
69-
function destroy_derived_children(signal) {
70-
destroy_effect_children(signal);
71-
var deriveds = signal.deriveds;
69+
function destroy_derived_children(derived) {
70+
destroy_effect_children(derived);
71+
var deriveds = derived.deriveds;
7272

7373
if (deriveds !== null) {
74-
signal.deriveds = null;
74+
derived.deriveds = null;
75+
7576
for (var i = 0; i < deriveds.length; i += 1) {
7677
destroy_derived(deriveds[i]);
7778
}

packages/svelte/src/internal/client/runtime.js

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -438,18 +438,17 @@ export function remove_reactions(signal, start_index) {
438438

439439
/**
440440
* @param {import('#client').Reaction} signal
441-
* @param {boolean} [remove_dom]
441+
* @param {boolean} remove_dom
442442
* @returns {void}
443443
*/
444-
export function destroy_effect_children(signal, remove_dom = true) {
445-
let effect = signal.first;
446-
signal.first = null;
447-
signal.last = null;
448-
var sibling;
444+
export function destroy_effect_children(signal, remove_dom = false) {
445+
var effect = signal.first;
446+
signal.first = signal.last = null;
447+
449448
while (effect !== null) {
450-
sibling = effect.next;
449+
var next = effect.next;
451450
destroy_effect(effect, remove_dom);
452-
effect = sibling;
451+
effect = next;
453452
}
454453
}
455454

0 commit comments

Comments
 (0)