Skip to content

Commit f126935

Browse files
paoloricciutipaoloricciuti
committed
fix: adjust test output
1 parent 6af745e commit f126935

File tree

6 files changed

+81
-27
lines changed

6 files changed

+81
-27
lines changed

‎packages/svelte/tests/runtime-legacy/samples/binding-circular/_config.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
import { test } from '../../test';
22

33
export default test({
4-
html: `
4+
ssrHtml: `
55
<select>
6-
<option value="[object Object]">wheeee</option>
6+
<option selected="" value="[object Object]">wheeee</option>
77
</select>
88
`
99
});

‎packages/svelte/tests/runtime-legacy/samples/binding-indirect/_config.js‎

Lines changed: 26 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,9 @@ export default test({
1717
return { tasks, selected: tasks[0] };
1818
},
1919

20-
html: `
20+
ssrHtml: `
2121
<select>
22-
<option value='[object Object]'>put your left leg in</option>
22+
<option selected="" value='[object Object]'>put your left leg in</option>
2323
<option value='[object Object]'>your left leg out</option>
2424
<option value='[object Object]'>in, out, in, out</option>
2525
<option value='[object Object]'>shake it all about</option>
@@ -36,7 +36,28 @@ export default test({
3636
<p>shake it all about</p>
3737
`,
3838

39-
async test({ assert, component, target, window }) {
39+
async test({ assert, component, target, window, variant }) {
40+
assert.htmlEqual(
41+
target.innerHTML,
42+
`
43+
<select>
44+
<option ${variant === 'hydrate' ? 'selected="" ' : ''}value='[object Object]'>put your left leg in</option>
45+
<option value='[object Object]'>your left leg out</option>
46+
<option value='[object Object]'>in, out, in, out</option>
47+
<option value='[object Object]'>shake it all about</option>
48+
</select>
49+
50+
<label>
51+
<input type='checkbox'> put your left leg in
52+
</label>
53+
54+
<h2>Pending tasks</h2>
55+
<p>put your left leg in</p>
56+
<p>your left leg out</p>
57+
<p>in, out, in, out</p>
58+
<p>shake it all about</p>
59+
`
60+
);
4061
const input = target.querySelector('input');
4162
const select = target.querySelector('select');
4263
const options = target.querySelectorAll('option');
@@ -57,7 +78,7 @@ export default test({
5778
target.innerHTML,
5879
`
5980
<select>
60-
<option value='[object Object]'>put your left leg in</option>
81+
<option ${variant === 'hydrate' ? 'selected="" ' : ''}value='[object Object]'>put your left leg in</option>
6182
<option value='[object Object]'>your left leg out</option>
6283
<option value='[object Object]'>in, out, in, out</option>
6384
<option value='[object Object]'>shake it all about</option>
@@ -94,7 +115,7 @@ export default test({
94115
target.innerHTML,
95116
`
96117
<select>
97-
<option value='[object Object]'>put your left leg in</option>
118+
<option ${variant === 'hydrate' ? 'selected="" ' : ''}value='[object Object]'>put your left leg in</option>
98119
<option value='[object Object]'>your left leg out</option>
99120
<option value='[object Object]'>in, out, in, out</option>
100121
<option value='[object Object]'>shake it all about</option>

‎packages/svelte/tests/runtime-legacy/samples/binding-select-implicit-option-value/_config.js‎

Lines changed: 16 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,17 +6,29 @@ export default test({
66
return { values: [1, 2, 3], foo: 2 };
77
},
88

9-
html: `
9+
ssrHtml: `
1010
<select>
1111
<option value="1">1</option>
12-
<option value="2">2</option>
12+
<option selected="" value="2">2</option>
1313
<option value="3">3</option>
1414
</select>
1515
1616
<p>foo: 2</p>
1717
`,
1818

19-
test({ assert, component, target, window }) {
19+
test({ assert, component, target, window, variant }) {
20+
assert.htmlEqual(
21+
target.innerHTML,
22+
`
23+
<select>
24+
<option value="1">1</option>
25+
<option ${variant === 'hydrate' ? 'selected="" ' : ''}value="2">2</option>
26+
<option value="3">3</option>
27+
</select>
28+
29+
<p>foo: 2</p>
30+
`
31+
);
2032
const select = target.querySelector('select');
2133
ok(select);
2234
const options = [...target.querySelectorAll('option')];
@@ -36,7 +48,7 @@ export default test({
3648
`
3749
<select>
3850
<option value="1">1</option>
39-
<option value="2">2</option>
51+
<option ${variant === 'hydrate' ? 'selected="" ' : ''}value="2">2</option>
4052
<option value="3">3</option>
4153
</select>
4254

‎packages/svelte/tests/runtime-legacy/samples/binding-select-in-each-block/_config.js‎

Lines changed: 18 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,15 @@
11
import { test } from '../../test';
22

33
export default test({
4-
html: `
4+
ssrHtml: `
55
<select>
6-
<option value='hullo'>Hullo</option>
6+
<option selected="" value='hullo'>Hullo</option>
77
<option value='world'>World</option>
88
</select>
99
1010
<select>
1111
<option value='hullo'>Hullo</option>
12-
<option value='world'>World</option>
12+
<option selected="" value='world'>World</option>
1313
</select>
1414
`,
1515

@@ -19,7 +19,21 @@ export default test({
1919
};
2020
},
2121

22-
test({ assert, component, target, window }) {
22+
test({ assert, component, target, window, variant }) {
23+
assert.htmlEqual(
24+
target.innerHTML,
25+
`
26+
<select>
27+
<option ${variant === 'hydrate' ? 'selected="" ' : ''}value='hullo'>Hullo</option>
28+
<option value='world'>World</option>
29+
</select>
30+
31+
<select>
32+
<option value='hullo'>Hullo</option>
33+
<option ${variant === 'hydrate' ? 'selected="" ' : ''}value='world'>World</option>
34+
</select>
35+
`
36+
);
2337
const selects = [...target.querySelectorAll('select')];
2438

2539
const change = new window.Event('change');

‎packages/svelte/tests/runtime-legacy/samples/select-in-each/_config.js‎

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,27 +2,28 @@ import { flushSync } from 'svelte';
22
import { ok, test } from '../../test';
33

44
export default test({
5-
html: `
6-
<select>
7-
<option selected="" value="a">A</option>
8-
<option value="b">B</option>
9-
</select>
10-
selected: a
11-
`,
12-
13-
test({ assert, target }) {
5+
test({ assert, target, variant }) {
6+
assert.htmlEqual(
7+
target.innerHTML,
8+
`
9+
<select>
10+
<option${variant === 'hydrate' ? ' selected=""' : ''} value="a">A</option$>
11+
<option value="b">B</option>
12+
</select>
13+
selected: a
14+
`
15+
);
1416
const select = target.querySelector('select');
1517
ok(select);
1618
const event = new window.Event('change');
1719
select.value = 'b';
1820
select.dispatchEvent(event);
1921
flushSync();
20-
2122
assert.htmlEqual(
2223
target.innerHTML,
2324
`
2425
<select>
25-
<option value="a">A</option>
26+
<option${variant === 'hydrate' ? ' selected=""' : ''} value="a">A</option$>
2627
<option value="b">B</option>
2728
</select>
2829
selected: b

‎packages/svelte/tests/runtime-runes/samples/bindings-form-reset/main.svelte‎

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,14 @@
33
let checkbox = $state(true);
44
let radio_group = $state('a');
55
let checkbox_group = $state(['a']);
6-
let select = $state('b');
6+
// this will be ssrd
7+
let select = $state('a');
78
let textarea = $state('textarea');
9+
10+
$effect(()=>{
11+
// changing the value of `select` on mount
12+
select = 'b';
13+
})
814
</script>
915

1016
<p>{JSON.stringify({ text, checkbox, radio_group, checkbox_group, select, textarea })}</p>

0 commit comments

Comments
 (0)