Skip to content

Commit f6c2433

Browse files
committed
handle irksome edge cases
1 parent 678ba79 commit f6c2433

File tree

3 files changed

+6
-4
lines changed
  • packages/svelte

3 files changed

+6
-4
lines changed

packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/utils.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -389,6 +389,8 @@ export function build_expression(context, expression, metadata, state = context.
389389

390390
if (
391391
binding.kind === 'bindable_prop' ||
392+
binding.kind === 'template' ||
393+
binding.declaration_kind === 'import' ||
392394
binding.node.name === '$$props' ||
393395
binding.node.name === '$$restProps'
394396
) {

packages/svelte/tests/runtime-legacy/samples/lifecycle-render-order-for-children/Item.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
export let index;
66
export let n;
77
8-
function logRender () {
8+
function logRender (n) {
99
order.push(`${index}: render ${n}`);
1010
return index;
1111
}
@@ -24,5 +24,5 @@
2424
</script>
2525

2626
<li>
27-
{logRender()}
27+
{logRender(n)}
2828
</li>

packages/svelte/tests/runtime-legacy/samples/lifecycle-render-order-for-children/main.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
66
export let n = 0;
77
8-
function logRender () {
8+
function logRender (n) {
99
order.push(`parent: render ${n}`);
1010
return 'parent';
1111
}
@@ -23,7 +23,7 @@
2323
})
2424
</script>
2525

26-
{logRender()}
26+
{logRender(n)}
2727
<ul>
2828
{#each [1,2,3] as index}
2929
<Item {index} {n} />

0 commit comments

Comments
 (0)