Skip to content

Commit f7a47d5

Browse files
committed
fix: ensure tracking returns true, even if in unowned
1 parent f67cf20 commit f7a47d5

File tree

4 files changed

+34
-1
lines changed

4 files changed

+34
-1
lines changed

.changeset/long-moles-join.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'svelte': patch
3+
---
4+
5+
fix: ensure tracking returns true, even if in unowned

packages/svelte/src/internal/client/reactivity/effects.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ export function effect_tracking() {
170170

171171
// If it's skipped, that's because we're inside an unowned
172172
// that is not being tracked by another reaction
173-
return !skip_reaction;
173+
return true;
174174
}
175175

176176
/**
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
import { flushSync } from 'svelte';
2+
import { test } from '../../test';
3+
4+
export default test({
5+
async test({ assert, target, logs }) {
6+
const b1 = target.querySelector('button');
7+
8+
b1?.click();
9+
flushSync();
10+
11+
assert.htmlEqual(
12+
target.innerHTML,
13+
`<o>Store: new</o><p>Text: new message</p><button>Change Store</button>`
14+
);
15+
}
16+
});
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
<script>
2+
import { writable, fromStore, toStore } from "svelte/store";
3+
4+
const store = writable("previous");
5+
let text = $derived(fromStore(store).current + " message");
6+
7+
const textStore = toStore(() => text);
8+
</script>
9+
10+
<o>Store: {$store}</o>
11+
<p>Text: {text}</p>
12+
<button onclick={() => { store.set("new"); }}>Change Store</button>

0 commit comments

Comments
 (0)