Skip to content

Conversation

@Ocean-OS
Copy link
Member

This ensures that during migration, $deriveds are only applied to Identifiers, and not object properties.
Fixes #13723.

Svelte 5 rewrite

Please note that the Svelte codebase is currently being rewritten for Svelte 5. Changes should target Svelte 5, which lives on the default branch (main).

If your PR concerns Svelte 4 (including updates to svelte.dev.docs), please ensure the base branch is svelte-4 and not main.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Ensure that $derived is only applied to Identifiers
@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: e831d52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dummdidumm
Copy link
Member

Looks good! Could you add a test (within tests/migrate) and add a changeset (via npx changeset at the root of the repo then follow the prompts)?

@Conduitry Conduitry changed the title Fix migration $derived bug fix: don't migrate $: foo.bar = baz to use $derived() Oct 21, 2024
@dummdidumm
Copy link
Member

merging this into #13740 and gonna add a test / changeset there - thank you!

@dummdidumm dummdidumm changed the base branch from main to derivation-fixes October 21, 2024 11:20
@dummdidumm dummdidumm merged commit 38738a8 into sveltejs:derivation-fixes Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Svelte 5: reactive statements migration error

2 participants