Skip to content

Conversation

@adiguba
Copy link
Contributor

@adiguba adiguba commented Oct 23, 2024

Some little improvement to set_style() in order to avoid the check to style.getPropertyValue()

See issue #13791

Demo here : REPL

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2024

⚠️ No Changeset found

Latest commit: e577cdd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@trueadm
Copy link
Contributor

trueadm commented Oct 24, 2024

You should also add __styles to the element_prototype in operations.js

@adiguba
Copy link
Contributor Author

adiguba commented Oct 24, 2024

You should also add __styles to the element_prototype in operations.js

Done !

Copy link
Contributor

@trueadm trueadm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@trueadm trueadm merged commit 7c7fd65 into sveltejs:main Oct 24, 2024
7 checks passed
@adiguba adiguba deleted the improve_set_style branch October 24, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants