fix: allow testing browser code in node #14019
Closed
+18
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 29b0141 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
benmccann
force-pushed
the
browser-node
branch
3 times, most recently
from
e4431e0 to
47ae3ab
Compare
benmccann
force-pushed
the
browser-node
branch
from
47ae3ab to
2a666ad
Compare
commit: |
commit: |
Member
|
wouldn't this prevent component testing wirh jsdom and a raf mock? i don't understand why we use these conditions instead of a simple one-time check if requestAnimationFrame exists as a global at runtime initialization. |
Member
Author
|
it wouldn't, but I was just about to close this with what I think is a simpler solution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13961
I tested this with the test project in that issue courtesy of our new pkg-pr-new setup and the tests passed