Skip to content

Conversation

@trueadm
Copy link
Contributor

@trueadm trueadm commented Nov 6, 2024

Follow up to #14186 (comment)

@changeset-bot
Copy link

changeset-bot bot commented Nov 6, 2024

⚠️ No Changeset found

Latest commit: 2076608

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14194-svelte.vercel.app/

this is an automated message

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14194

@paoloricciuti
Copy link
Member

Using on was breaking stuff? 😄

@trueadm
Copy link
Contributor Author

trueadm commented Nov 6, 2024

@paoloricciuti Nope. It just added a bit more overhead that we can avoid because we don't need to handle delegation.

@paoloricciuti
Copy link
Member

@paoloricciuti Nope. It just added a bit more overhead that we can avoid because we don't need to handle delegation.

Gotcha...let me just check from the PC for good measure but this lgtm

@trueadm trueadm merged commit 7eb4cb9 into main Nov 7, 2024
11 checks passed
@trueadm trueadm deleted the bindings-context branch November 7, 2024 08:58
trueadm added a commit that referenced this pull request Nov 7, 2024
* chore: ensure binding events are without context

* doh
dummdidumm added a commit that referenced this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants