fix: addresses memory leak when creating deriveds inside untrack #14443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b16eb5f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Member
|
preview: https://svelte-dev-git-preview-svelte-14443-svelte.vercel.app/ this is an automated message |
Contributor
|
dummdidumm
reviewed
Nov 26, 2024
Rich-Harris
reviewed
Nov 26, 2024
Rich-Harris
approved these changes
Nov 26, 2024
Rich-Harris
reviewed
Nov 26, 2024
Rich-Harris
reviewed
Nov 26, 2024
Rich-Harris
approved these changes
Nov 26, 2024
Co-authored-by: Rich Harris <[email protected]>
Co-authored-by: Rich Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was an odd memory leak that I've been tracking for weeks. I made the discovery today whilst looking into another issue that it was to do with
untrack. Specifically, we only attach a derived to the parent effect when we're in a non tracking context – however, because nested deriveds only recorded their parent as effect, it meant that nested deriveds were incorrectly being added to the same effect after each run.Rather than have the awkwardly deal with removing a derived from the parent each time, and know that deriveds can only be created where they are declared, we can instead just make the parent of a derived by that of an effect or another derived.