Skip to content

Conversation

@trueadm
Copy link
Contributor

@trueadm trueadm commented Jan 7, 2025

I want to keep us better aligned with the official benchmark which also uses 1000 iterations, rather than 100.

https://github.com/milomg/js-reactivity-benchmark/blob/main/src/kairoBench.ts#L36

We couldn't do this before because our old signal implementation was too slow and it added on several minutes to the the CI time, but we can now since we fixed those perf issues many months ago. This will help with tuning our existing implementation too – as the number of iterations will better reflect the overhead.

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025

⚠️ No Changeset found

Latest commit: 8dfc958

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025

Playground

pnpm add https://pkg.pr.new/svelte@14944

@Rich-Harris Rich-Harris merged commit deb362f into main Jan 8, 2025
11 checks passed
@Rich-Harris Rich-Harris deleted the expand-benchmarks branch January 8, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants