Skip to content

Conversation

@dummdidumm
Copy link
Member

The component identity could change due to HMR, so we fall back to checking the filenames as well

No test because this requires HMR and changes to a file being made.

fixes #14746

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

The component identity could change due to HMR, so we fall back to checking the filenames as well

fixes #14746
@changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2025

🦋 Changeset detected

Latest commit: 6550d27

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@15154

@dummdidumm dummdidumm merged commit 970aa7c into main Jan 30, 2025
10 checks passed
@dummdidumm dummdidumm deleted the ownership-hmr-fix branch January 30, 2025 18:15
This was referenced Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

False positive of ownership_invalid_mutation after hot reload

3 participants