Skip to content

Conversation

@paoloricciuti
Copy link
Member

Alternative to #15409 ...not the same improvements as it only really works for components that starts with Text, Await and Key but an improvement nontheless...i think we might be able to expand to other blocks too with a bit more code but let's start with this.

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2025

🦋 Changeset detected

Latest commit: 777c4dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paoloricciuti
Copy link
Member Author

@adiguba you might want to take a look at this

@svelte-docs-bot
Copy link

@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

Playground

pnpm add https://pkg.pr.new/svelte@15417

@paoloricciuti
Copy link
Member Author

Uh i think I need to rename some variable

@dummdidumm
Copy link
Member

Slightly prefer this to #15409 though can't shake the feeling that YAGNI

@paoloricciuti
Copy link
Member Author

Slightly prefer this to #15409 though can't shake the feeling that YAGNI

Yeah at the end of the day it's not revolutionary...just thought this was simpler enough to maintain and it's still one less hydration marker for those cases. But we can close this into oblivion if you prefer, I'm not attached lol

@Rich-Harris
Copy link
Member

Echoing my comments from #15409 — this eats into our complexity budget and I'm not sure what we get in return is dramatic enough for it to be a good investment, so I'll close it

@Rich-Harris Rich-Harris closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants