Example use of $effect inside attachment seams to be redundant

[machadinhos]

Describe the bug

Hi.

I've noticed that in the docs for the new attachments in the Inline attachments section a $effect is used, but it appears to not have any effect. It doesn't have any effect to the example, and it also appear to not have any effect to the cleanup, because, as shown by the Attachment factories section functions returned from an attachment are cleanup functions them selves because the attachment runs inside an "invisible" $effect.

Can anyone confirm this suspicion I have?

Thank you!

Reproduction

Removing the $effect from the demo appear to have no effect.

Logs

System Info

N.A.

Severity

annoyance

[MotionlessTrain]

Is already fixed by #15920. Rich seemed to notice it around the same time

[machadinhos]

Nooo I had the fix ready to go. Almost became a svelte continuator hahaha
Maybe next time :D