App crashes trying to redefine `message` getter on the thrown Error if the error already contains the message as getter

[mifopen]

Describe the bug

E.g. it's impossible to run Zod validations on client because in the new versions Zod reimplemented errors and using calculable message property now.

Reproduction

Throw an object inherited from Error and with message field defined as getter property.

Logs

TypeError: Cannot redefine property: message
    at defineProperty (<anonymous>)
    at handle_error (.../node_modules/.vite/deps/...)

System Info

-

Severity

blocking all usage of svelte

[dummdidumm]

Please provide a reproduction using the playground - you can import zod there.

[mifopen]

https://svelte.dev/playground/32990af8d4574af184c80acb5e5f9640?version=5.34.1

[sukeshpabolu]

zod will throw the error if you just use parse. This is not a problem with svelte. Using safeParse works

[paoloricciuti]

I think the problem here is a bit different...yeah Zod will throw the error but it should be a Zod error, svelte is trying to create a message property on it generating a different error because it already exists.

[sukeshpabolu]

I think the problem here is a bit different...yeah Zod will throw the error but it should be a Zod error, svelte is trying to create a message property on it generating a different error because it already exists.

I think this not related to zod itself then. I observed similar issue with the CustomError class I created here which can be used as minimal repro too.

[paoloricciuti]

Yeah it's not related to Zod, svelte in dev is trying to print more useful errors but in doing so it tries to redefind message if this was already done previously in a non configurable way it will throw, we need to fix this 😄

[paoloricciuti]

But your repro is not a good repro, your error is actually thrown and displayed correctly, the zod error is swallowed by svelte trying to change the message