Skip to content

Conversation

@Rich-Harris
Copy link
Member

was looking into whether we could use the new update_version mechanism to make it cheaper to answer 'was this source created inside the current reaction?', and noticed that we're currently doing a check inside a loop that should be outside, since the answer is always the same

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@16328

@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2025

⚠️ No Changeset found

Latest commit: 7ee8cfb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any code inside the loop that would cause side effects so I think it's good...

@Rich-Harris Rich-Harris merged commit 71ed9e4 into main Jul 10, 2025
14 checks passed
@Rich-Harris Rich-Harris deleted the tweak branch July 10, 2025 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants