Skip to content

Comments

test: add regression test for dir attribute with siblings (#15126)#17736

Closed
apoorvdarshan wants to merge 1 commit intosveltejs:mainfrom
apoorvdarshan:fix/dir-attribute-siblings-regression-test
Closed

test: add regression test for dir attribute with siblings (#15126)#17736
apoorvdarshan wants to merge 1 commit intosveltejs:mainfrom
apoorvdarshan:fix/dir-attribute-siblings-regression-test

Conversation

@apoorvdarshan
Copy link

Summary

Test plan

  • New test passes in all 4 modes: dom, hydrate, ssr, async-ssr
  • Covers the exact reproduction from the issue (multiple dir="auto" elements with siblings)

…5126)

Elements with `dir="auto"` previously caused a compiler crash
("Cannot read properties of null") when sibling content was present.
The bug has since been fixed, but no regression test existed.
@changeset-bot
Copy link

changeset-bot bot commented Feb 18, 2026

⚠️ No Changeset found

Latest commit: 160d27d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

thank you but a test was already added in #15259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants