Skip to content

Conversation

@xxkl1
Copy link
Contributor

@xxkl1 xxkl1 commented Jul 4, 2023

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

closes: #8533

transition slide will become not smooth with min-height and min-width.
https://svelte.dev/repl/90fdf9a3faa645aaa1e18201cf29e9cf?version=4.0.3

transition slide not smooth when with min height or min width.

I think we can set min-height or min-width to be 0 to keep slide smooth when run animation.

I didn't add a test case because I don't know how to test this case.

I'd be happy to add test cases, if any suggestions can be given.

@roberrrt-s
Copy link

Bumping for visibility, would love to see this.

@Rich-Harris
Copy link
Member

thank you and sorry for the delay! Have opened a fresh PR since this now targets the svelte-4 branch — #14942

@Rich-Harris Rich-Harris closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Slide Transition should have min-height/width set to 0

4 participants