From 3f0e6b68a6bd6739970512365e7b8601cc9f40f9 Mon Sep 17 00:00:00 2001 From: Mathias Date: Wed, 15 May 2024 04:43:47 +0200 Subject: [PATCH 1/3] chore: use CustomEvent constructor instead of deprecated createEvent method --- .../internal/client/dom/elements/transitions.js | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/packages/svelte/src/internal/client/dom/elements/transitions.js b/packages/svelte/src/internal/client/dom/elements/transitions.js index 3551a093da1d..e31bc2d10951 100644 --- a/packages/svelte/src/internal/client/dom/elements/transitions.js +++ b/packages/svelte/src/internal/client/dom/elements/transitions.js @@ -9,26 +9,13 @@ import { current_each_item } from '../blocks/each.js'; import { TRANSITION_GLOBAL, TRANSITION_IN, TRANSITION_OUT } from '../../../../constants.js'; import { BLOCK_EFFECT, EFFECT_RAN, EFFECT_TRANSPARENT } from '../../constants.js'; -/** - * @template T - * @param {string} type - * @param {T} [detail] - * @param {any}params_0 - * @returns {Event} - */ -function custom_event(type, detail, { bubbles = false, cancelable = false } = {}) { - const e = document.createEvent('CustomEvent'); - e.initCustomEvent(type, bubbles, cancelable, detail); - return e; -} - /** * @param {Element} dom * @param {'introstart' | 'introend' | 'outrostart' | 'outroend'} type * @returns {void} */ function dispatch_event(dom, type) { - dom.dispatchEvent(custom_event(type)); + dom.dispatchEvent(new CustomEvent(type)); } /** From 4b8641f8d675d896875dc2241ed198a2937321d8 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Wed, 15 May 2024 12:29:24 -0400 Subject: [PATCH 2/3] while we're here... --- .../svelte/src/internal/client/dom/elements/transitions.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/svelte/src/internal/client/dom/elements/transitions.js b/packages/svelte/src/internal/client/dom/elements/transitions.js index e31bc2d10951..cff1cce746ed 100644 --- a/packages/svelte/src/internal/client/dom/elements/transitions.js +++ b/packages/svelte/src/internal/client/dom/elements/transitions.js @@ -10,12 +10,12 @@ import { TRANSITION_GLOBAL, TRANSITION_IN, TRANSITION_OUT } from '../../../../co import { BLOCK_EFFECT, EFFECT_RAN, EFFECT_TRANSPARENT } from '../../constants.js'; /** - * @param {Element} dom + * @param {Element} element * @param {'introstart' | 'introend' | 'outrostart' | 'outroend'} type * @returns {void} */ -function dispatch_event(dom, type) { - dom.dispatchEvent(new CustomEvent(type)); +function dispatch_event(element, type) { + element.dispatchEvent(new CustomEvent(type)); } /** From c118e6187fbee1ffb581cfe796528b99f590190f Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Wed, 15 May 2024 12:29:52 -0400 Subject: [PATCH 3/3] changeset --- .changeset/yellow-trees-juggle.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/yellow-trees-juggle.md diff --git a/.changeset/yellow-trees-juggle.md b/.changeset/yellow-trees-juggle.md new file mode 100644 index 000000000000..64642597e2ea --- /dev/null +++ b/.changeset/yellow-trees-juggle.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +chore: use `new CustomEvent` instead of deprecated `initCustomEvent`