Skip to content

Conversation

@panyang05
Copy link
Contributor

This pull request introduces the ability to allow unquoted slashes in attributes within the Svelte compiler. The key changes include modifications to the parser to handle unquoted slashes, as well as updates to the test cases to ensure this new feature is properly validated.

Changes to the Svelte compiler:

Updates to test cases:

Documentation:

Issues Related:
#7782

@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2024

🦋 Changeset detected

Latest commit: ea9d4cf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14615-svelte.vercel.app/

this is an automated message

@panyang05 panyang05 marked this pull request as ready for review December 8, 2024 16:25
@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Playground

pnpm add https://pkg.pr.new/svelte@14615

@Rich-Harris
Copy link
Member

Thank you — this fails with <a href=/foo>, any chance you can look into that and augment the test to cover both cases?

@panyang05
Copy link
Contributor Author

panyang05 commented Dec 12, 2024

Thank you — this fails with <a href=/foo>, any chance you can look into that and augment the test to cover both cases?

Hi, please let me know if this fixes the issue. Thanks!

@Rich-Harris Rich-Harris merged commit 88c2d6e into sveltejs:main Dec 12, 2024
10 checks passed
@Rich-Harris
Copy link
Member

perfect, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants