Skip to content

fix: avoid mutation validation for invalidate_inner_signals #14688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trueadm merged 3 commits into from
Dec 12, 2024
Merged

fix: avoid mutation validation for invalidate_inner_signals #14688

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73398f1
fix: avoid mutation validation for invalidate_inner_signals
trueadm Dec 12, 2024
b9f0273
add test
trueadm Dec 12, 2024
3b395e7
Update packages/svelte/src/internal/client/runtime.js
dummdidumm Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/strong-pandas-provide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: avoid mutation validation for invalidate_inner_signals
6 changes: 3 additions & 3 deletions packages/svelte/src/internal/client/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import {
} from './constants.js';
import { flush_tasks } from './dom/task.js';
import { add_owner } from './dev/ownership.js';
import { mutate, set, source } from './reactivity/sources.js';
import { internal_set, set, source } from './reactivity/sources.js';
import { destroy_derived, execute_derived, update_derived } from './reactivity/deriveds.js';
import * as e from './errors.js';
import { lifecycle_outside_component } from '../shared/errors.js';
Expand Down Expand Up @@ -960,11 +960,11 @@ export function invalidate_inner_signals(fn) {
if ((signal.f & LEGACY_DERIVED_PROP) !== 0) {
for (const dep of /** @type {Derived} */ (signal).deps || []) {
if ((dep.f & DERIVED) === 0) {
mutate(dep, null /* doesnt matter */);
internal_set(dep, dep.v);
}
}
} else {
mutate(signal, null /* doesnt matter */);
internal_set(signal, signal.v);
}
}
}
Expand Down
12 changes: 12 additions & 0 deletions packages/svelte/tests/runtime-runes/samples/binding-interop-derived/Comp.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
<script>

let { children } = $props()

const snippetProps = $derived.by(() => ({
id: '123',
name: 'my-select'
}))

</script>

{@render children({ props: snippetProps })}
5 changes: 5 additions & 0 deletions packages/svelte/tests/runtime-runes/samples/binding-interop-derived/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
import { test } from '../../test';

export default test({
html: '<select id="123" name="my-select"><option>A</option><option>B</option><option>C</option></select>'
});
19 changes: 19 additions & 0 deletions packages/svelte/tests/runtime-runes/samples/binding-interop-derived/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
<svelte:options runes={false} />

<script>
import { writable } from 'svelte/store'
import Comp from './Comp.svelte'

const myStore = writable('')

</script>

<Comp>
{#snippet children({ props })}
<select {...props} bind:value={$myStore} >
<option>A</option>
<option>B</option>
<option>C</option>
</select>
{/snippet}
</Comp>
Loading