Skip to content

fix: ensure svg namespace for <a> elements is correct #14756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trueadm merged 4 commits into from
Dec 18, 2024
Merged

fix: ensure svg namespace for <a> elements is correct #14756

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b0819b7
fix: ensure svg namespace persists from parent of if blocks
trueadm Dec 18, 2024
f9702b5
better fix
trueadm Dec 18, 2024
208ff6d
better fix
trueadm Dec 18, 2024
ef8c56e
address feedback
trueadm Dec 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/nine-buses-own.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: ensure svg namespace for `<a>` elements is correct
5 changes: 4 additions & 1 deletion packages/svelte/src/compiler/phases/2-analyze/visitors/RegularElement.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ export function RegularElement(node, context) {
(attribute) => attribute.type === 'SpreadAttribute'
);

node.metadata.svg = is_svg(node.name);
node.metadata.svg =
is_svg(node.name) ||
(node.name === 'a' &&
context.path.some((n) => n.type === 'RegularElement' && n.name === 'svg'));
node.metadata.mathml = is_mathml(node.name);

if (is_custom_element_node(node) && node.attributes.length > 0) {
Expand Down
11 changes: 11 additions & 0 deletions packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-2/_config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
import { test, ok } from '../../test';

export default test({
html: `<svg><a href="/docs"><text class="small" x="20" y="40"></text></a></svg>`,
test({ assert, target }) {
const a = target.querySelector('a');
ok(a);

assert.equal(a.namespaceURI, 'http://www.w3.org/2000/svg');
}
});
7 changes: 7 additions & 0 deletions packages/svelte/tests/runtime-runes/samples/svg-namespace-if-block-2/main.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<svg>
{#if true}
<a href="/docs">
<text x="20" y="40" class="small">{name}</text>
</a>
{/if}
</svg>
Loading