Skip to content

Conversation

@trueadm
Copy link
Contributor

@trueadm trueadm commented Jan 9, 2025

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Jan 9, 2025

🦋 Changeset detected

Latest commit: b428f01

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-svelte-14964-svelte.vercel.app/

this is an automated message

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Playground

pnpm add https://pkg.pr.new/svelte@14964

@paoloricciuti
Copy link
Member

Still not the complete fix: it only works the first time

REPL

@trueadm
Copy link
Contributor Author

trueadm commented Jan 9, 2025

Still not the complete fix: it only works the first time

REPL

Put up a better fix

@trueadm trueadm marked this pull request as ready for review January 9, 2025 16:20
@Rich-Harris Rich-Harris merged commit bdc0200 into main Jan 9, 2025
11 checks passed
@Rich-Harris Rich-Harris deleted the read-version-fix branch January 9, 2025 16:26
@github-actions github-actions bot mentioned this pull request Jan 9, 2025
@paoloricciuti
Copy link
Member

We just beat the record for most collaborators on the minimal change

1 fix from @trueadm
1 comment from @dummdidumm
1 test from @paoloricciuti
1 changeset from @Rich-Harris

lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants