From d09b865f05b9dc8ab1723671627e8716cac4fc69 Mon Sep 17 00:00:00 2001 From: Trevor Suarez Date: Tue, 21 Jan 2025 18:49:04 -0700 Subject: [PATCH 1/4] Adding a test for `novalidate` attribute casing --- .../samples/form-novalidate-casing/_config.js | 8 ++++++++ .../samples/form-novalidate-casing/main.svelte | 6 ++++++ 2 files changed, 14 insertions(+) create mode 100644 packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/_config.js create mode 100644 packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/main.svelte diff --git a/packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/_config.js b/packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/_config.js new file mode 100644 index 000000000000..c7a48b3d8129 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/_config.js @@ -0,0 +1,8 @@ +import { test } from '../../test'; + +export default test({ + html: ` +
+
+` +}); diff --git a/packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/main.svelte b/packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/main.svelte new file mode 100644 index 000000000000..1e8115ff6263 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/main.svelte @@ -0,0 +1,6 @@ + + +
+
From 5f43ad85cb857fef05dbb21ea87860d88aaa3193 Mon Sep 17 00:00:00 2001 From: Trevor Suarez Date: Tue, 21 Jan 2025 18:50:02 -0700 Subject: [PATCH 2/4] Adding handling for `novalidate` attribute casing --- packages/svelte/src/utils.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/svelte/src/utils.js b/packages/svelte/src/utils.js index 76486d32ac4e..b16c0551f192 100644 --- a/packages/svelte/src/utils.js +++ b/packages/svelte/src/utils.js @@ -196,7 +196,8 @@ const ATTRIBUTE_ALIASES = { readonly: 'readOnly', defaultvalue: 'defaultValue', defaultchecked: 'defaultChecked', - srcobject: 'srcObject' + srcobject: 'srcObject', + novalidate: 'noValidate' }; /** From 50106c0651bbd8c5640dad28f528a03b2c9183ee Mon Sep 17 00:00:00 2001 From: Trevor Suarez Date: Tue, 21 Jan 2025 18:55:48 -0700 Subject: [PATCH 3/4] Adding changeset --- .changeset/pink-wolves-search.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/pink-wolves-search.md diff --git a/.changeset/pink-wolves-search.md b/.changeset/pink-wolves-search.md new file mode 100644 index 000000000000..cd734062c6fa --- /dev/null +++ b/.changeset/pink-wolves-search.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: correctly handle `novalidate` attribute casing From 304b613d0dcf9b040647db27fac02f5b89184ef0 Mon Sep 17 00:00:00 2001 From: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Wed, 22 Jan 2025 10:45:35 +0100 Subject: [PATCH 4/4] Update packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/_config.js --- .../runtime-runes/samples/form-novalidate-casing/_config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/_config.js b/packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/_config.js index c7a48b3d8129..4fdf3632d650 100644 --- a/packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/_config.js +++ b/packages/svelte/tests/runtime-runes/samples/form-novalidate-casing/_config.js @@ -1,7 +1,7 @@ import { test } from '../../test'; export default test({ - html: ` + html: `
`