chore: update banner faster under theme change #15320
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).This PR refactors the banner part in the readme in order for it to detect the theme faster as illustrated below.
Old (the banner clearly lags behind in updating):
https://github.com/user-attachments/assets/ed2cc76c-7f18-4644-978f-0e6facbfc4f6
New (no log when switching themes):
https://github.com/user-attachments/assets/9eb4144b-5d3a-4dd2-91e9-27840e549fa2
The lag problem in the first example will get slightly better when switching theme for the second time, but the same amount of lag appears when refreshing and then switching.