Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/proud-poems-brake.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: correctly set `is_updating` before flushing root effects
4 changes: 4 additions & 0 deletions packages/svelte/src/internal/client/runtime.js
Original file line number Diff line number Diff line change
Expand Up @@ -644,8 +644,11 @@ function infinite_loop_guard() {
}

function flush_queued_root_effects() {
var was_updating_effect = is_updating_effect;

try {
var flush_count = 0;
is_updating_effect = true;

while (queued_root_effects.length > 0) {
if (flush_count++ > 1000) {
Expand All @@ -670,6 +673,7 @@ function flush_queued_root_effects() {
}
} finally {
is_flushing = false;
is_updating_effect = was_updating_effect;

last_scheduled_effect = null;
if (DEV) {
Expand Down
41 changes: 41 additions & 0 deletions packages/svelte/tests/signals/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1135,4 +1135,45 @@ describe('signals', () => {
destroy();
};
});

test('unowned deriveds correctly update', () => {
const log: any[] = [];

return () => {
const a = state(0);
const b = state(0);
const c = derived(() => {
return $.get(a);
});
const d = derived(() => {
return $.get(b);
});

const destroy = effect_root(() => {
const e = derived(() => {
return $.get(c) === 1 && $.get(d) === 1;
});
render_effect(() => {
log.push($.get(e));
});
});

assert.deepEqual(log, [false]);

set(a, 1);
set(b, 1);

flushSync();

assert.deepEqual(log, [false, true]);

set(b, 9);

flushSync();

assert.deepEqual(log, [false, true, false]);

destroy();
};
});
});