From 4f7455c5c3d97a983745456c9e846ecd086ee049 Mon Sep 17 00:00:00 2001 From: Trevor Suarez Date: Wed, 5 Mar 2025 19:25:37 -0700 Subject: [PATCH 1/3] Adding the `closedby` attribute to dialog element Spec: https://html.spec.whatwg.org/#attr-dialog-closedby --- packages/svelte/elements.d.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/svelte/elements.d.ts b/packages/svelte/elements.d.ts index 6d256b56205c..08687cafaf14 100644 --- a/packages/svelte/elements.d.ts +++ b/packages/svelte/elements.d.ts @@ -957,6 +957,7 @@ export interface HTMLDelAttributes extends HTMLAttributes { export interface HTMLDialogAttributes extends HTMLAttributes { open?: boolean | undefined | null; + closedby?: 'any' | 'closerequest' | 'none' | undefined | null; } export interface HTMLEmbedAttributes extends HTMLAttributes { From 84fb0e7d76b3dd60901d5210fe37b721c4d5406b Mon Sep 17 00:00:00 2001 From: Trevor Suarez Date: Wed, 5 Mar 2025 19:31:53 -0700 Subject: [PATCH 2/3] Adding changeset --- .changeset/metal-spoons-scream.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/metal-spoons-scream.md diff --git a/.changeset/metal-spoons-scream.md b/.changeset/metal-spoons-scream.md new file mode 100644 index 000000000000..885106584c01 --- /dev/null +++ b/.changeset/metal-spoons-scream.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +feat: Add `closedby` property to HTMLDialogAttributes type From d00f77bd5f4a8b758760ed679a719c812e6c71a0 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Fri, 7 Mar 2025 10:01:57 -0500 Subject: [PATCH 3/3] Update .changeset/metal-spoons-scream.md --- .changeset/metal-spoons-scream.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/metal-spoons-scream.md b/.changeset/metal-spoons-scream.md index 885106584c01..2eb7b7140cf9 100644 --- a/.changeset/metal-spoons-scream.md +++ b/.changeset/metal-spoons-scream.md @@ -2,4 +2,4 @@ 'svelte': patch --- -feat: Add `closedby` property to HTMLDialogAttributes type +fix: Add `closedby` property to HTMLDialogAttributes type