Skip to content

fix: reuse already attached attachments in spread attributes #15951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

fix: reuse already attached attachments in spread attributes #15951

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
049b5a0
fix: reuse already attached attachments from spread attributes
Ocean-OS May 18, 2025
c1932aa
oops
Ocean-OS May 18, 2025
2c45b7e
try this
Ocean-OS May 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/rotten-lizards-remember.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: reuse already attached attachments from spread attributes
5 changes: 4 additions & 1 deletion packages/svelte/src/internal/client/dom/elements/attributes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,7 +448,10 @@ export function set_attributes(element, prev, next, css_hash, skip_warning = fal
}

for (let symbol of Object.getOwnPropertySymbols(next)) {
if (symbol.description === ATTACHMENT_KEY) {
if (
symbol.description === ATTACHMENT_KEY &&
(prev == undefined || !(symbol in prev) || prev[symbol] !== next[symbol])
) {
attach(element, () => next[symbol]);
}
}
Expand Down